Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only download a single tailwindcss binary #2765

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Only download a single tailwindcss binary #2765

merged 2 commits into from
Oct 10, 2024

Conversation

cuihtlauac
Copy link
Collaborator

@cuihtlauac cuihtlauac commented Oct 10, 2024

Only download a single tailwindcss binary

Bring back stuff removed when merging #2718

@tmattio
Copy link
Collaborator

tmattio commented Oct 10, 2024

I am not sure how adding a default alias tells dune to download a single binary?
The alias wasn't used anywhere, we're using the binary directly.

@cuihtlauac
Copy link
Collaborator Author

cuihtlauac commented Oct 10, 2024

If default is not restricted to taildwindcss, it also contains the 4 platform specific binaries. Without this restriction, just doing make clean and make build downloads the 4 binaries.

Incidentally, having the binary copied to the local switch allowed it to survive dune clean

@tmattio
Copy link
Collaborator

tmattio commented Oct 10, 2024

That's a behaviour of Dune I didn't know about, thanks!

@tmattio tmattio merged commit a0a850a into main Oct 10, 2024
3 checks passed
@tmattio tmattio deleted the amend-2718 branch October 10, 2024 11:41
@cuihtlauac cuihtlauac changed the title On download a single tailwindcss binary Only download a single tailwindcss binary Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants