Books Block Component [Learn Area Redesign] #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SaySayo
force-pushed
the
learn-book-component
branch
from
a7423b3
to
0f41be9
Compare
SaySayo
force-pushed
the
learn-book-component
branch
2 times, most recently
from
c18738a
to
3846b65
Compare
SaySayo
force-pushed
the
learn-book-component
branch
from
5c717f9
to
fb9826e
Compare
sabine
reviewed
Aug 29, 2023
| <div class="w-full bg-default flex h-full p-4 md:w-1/2"> | ||
| <div class="w-96 sm:w-auto lg:ml-auto lg:pr-4"> | ||
| <div class="pt-4 text-default text-sm font-medium leading-7 tracking-widest"> BOOK </div> | ||
| <h2 class="mt-2 text-default text-2xl font-normal leading-7"> Recommended Books </h2> |
There was a problem hiding this comment.
I suggest to make the title a parameter of the component, so that we can say something like "Books for Beginners"
sabine
reviewed
Aug 29, 2023
| = | ||
| <div class="w-full bg-default flex h-full p-4 md:w-1/2"> | ||
| <div class="w-96 sm:w-auto lg:ml-auto lg:pr-4"> | ||
| <div class="pt-4 text-default text-sm font-medium leading-7 tracking-widest"> BOOK </div> |
There was a problem hiding this comment.
Suggested change
| <div class="pt-4 text-default text-sm font-medium leading-7 tracking-widest"> BOOK </div> | |
| <div class="pt-4 text-default text-sm font-medium leading-7 tracking-widest"> BOOKS </div> |
christinerose
approved these changes
Sep 2, 2023
christinerose
approved these changes
Sep 4, 2023
| @@ -17,15 +20,15 @@ featured: false | |||
| difficulty: intermediate | |||
| --- | |||
|
|
|||
| In "More OCaml" John Whitington takes a meandering tour of functional | |||
| In "More OCaml," John Whitington takes a meandering tour of functional | |||
| programming with OCaml, introducing various language features and describing | |||
| some classic algorithms. The book ends with a large worked example dealing with | |||
There was a problem hiding this comment.
What does "large worked example" mean? A large project?
sabine
force-pushed
the
learn-book-component
branch
from
fa876be
to
c0e157f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created the books component according to the learn area redesign.
Design
Current look
