Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re: Rewrite merlin-completion-at-point integration to be faster and better #1827
base: main
Are you sure you want to change the base?
Re: Rewrite merlin-completion-at-point integration to be faster and better #1827
Changes from 5 commits
da2bb4e
2966b1e
f94912c
97b0244
1054246
49d97d5
a72fd55
38a9982
a05e514
7e137ba
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is right any more. From a packaging point of view,
merlin
,merlin-ac
,merlin-company
andmerlin-iedit
are separate packages, because their dependencies are different. Each is built into a separate MELPA package, for granular installation.However, presumably the intention is that
merlin-cap
will be part of the basemerlin
package, since it doesn't depend on anything opinionated that ships separately from Emacs. So it wouldn't be appropriate to runpackage-lint
onmerlin-cap
separately: instead, runpackage-lint
on bothmerlin-cap.el
andmerlin.el
together, with thepackage-lint-main-file
variable set tomerlin.el
.And
merlin-cap-test.el
doesn't need package-linting, because it's not shipped in the package.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I did that in a72fd55.
There a still spurious
merlin-cap.el: error: You should depend on (emacs "28.1") if you need
string-search'.` even if we use the compat module.