Skip to content

Commit

Permalink
Merge pull request #1795 from xvw/fix-1794
Browse files Browse the repository at this point in the history
Fix #1794: Add `-unboxed-types` and `-no-unboxed-types` to ignored flags
  • Loading branch information
voodoos committed Jul 8, 2024
2 parents d5bc15a + 68c5d3c commit ec6d2fb
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ unreleased
+ merlin binary
- A new `WRAPPING_PREFIX` configuration directive that can be used to tell Merlin
what to append to the current unit name in the presence of wrapping (#1788)
- Add `-unboxed-types` and `-no-unboxed-types` as ocaml ignored flags (#1795, fixes #1794)

merlin 5.1
==========
Expand Down
8 changes: 4 additions & 4 deletions src/kernel/mconfig.ml
Original file line number Diff line number Diff line change
Expand Up @@ -457,10 +457,10 @@ let ocaml_ignored_flags = [
"-noautolink"; "-no-check-prims"; "-nodynlink"; "-no-float-const-prop";
"-no-keep-locs"; "-no-principal"; "-no-rectypes"; "-no-strict-formats";
"-no-strict-sequence"; "-no-unbox-free-vars-of-clos";
"-no-unbox-specialised-args"; "-O2"; "-O3"; "-Oclassic"; "-opaque";
"-output-complete-obj"; "-output-obj"; "-p"; "-pack";
"-remove-unused-arguments"; "-S"; "-shared"; "-unbox-closures"; "-v";
"-verbose"; "-where";
"-no-unbox-specialised-args"; "-no-unboxed-types"; "-O2"; "-O3";
"-Oclassic"; "-opaque"; "-output-complete-obj"; "-output-obj"; "-p"; "-pack";
"-remove-unused-arguments"; "-S"; "-shared"; "-unbox-closures";
"-unboxed-types"; "-v"; "-verbose"; "-where";
]

let ocaml_ignored_parametrized_flags = [
Expand Down
13 changes: 13 additions & 0 deletions tests/test-dirs/errors/issue1794.t
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
$ $MERLIN single errors -filename main.ml -unboxed-types
{
"class": "return",
"value": [],
"notifications": []
}

$ $MERLIN single errors -filename main.ml -no-unboxed-types
{
"class": "return",
"value": [],
"notifications": []
}

0 comments on commit ec6d2fb

Please sign in to comment.