Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add new exercises #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EmileRolley
Copy link

@EmileRolley EmileRolley commented Jun 24, 2021

Add new exercises from the https://github.com/acamanes/ocaml-public repository.

Questions

  1. Currently, arbitrary names are used. Any better idea?
  2. I'm not sure keeping the mine exercice is still necessary. Should it be removed?

Changelog

  • Remove bst, random_access_lists and mine exercises.
  • Add public_exercices subdirectory, which contains the new exercises.
  • Update ./exercises/index.json

@EmileRolley EmileRolley marked this pull request as draft June 24, 2021 16:31
@EmileRolley EmileRolley marked this pull request as ready for review June 24, 2021 16:31
@EmileRolley EmileRolley changed the title feat(corpus): add new exercises Feat: add new exercises Jun 24, 2021
@yurug
Copy link
Contributor

yurug commented Jun 24, 2021

Add new exercises from the https://github.com/acamanes/ocaml-public repository.

Questions

  1. Currently, arbitrary names are used. Any better idea?

Which names are you referring to?

  1. I'm not sure keeping the mine exercice is still necessary. Should it be removed?

Sure.

Changelog

  • Move bst and random_access_lists exercises into the new directory./exercises/demo.

Why not just remove them?

  • Add public_exercices subdirectory, which contains the new exercises.

Hmm, is it compatible with static deployment?

@EmileRolley
Copy link
Author

Which names are you referring to?

Mostly group titles and directory names.

Hmm, is it compatible with static deployment?

Screenshot from 2021-06-24 18-54-55

@EmileRolley EmileRolley marked this pull request as draft June 24, 2021 17:38
@EmileRolley EmileRolley marked this pull request as ready for review June 24, 2021 17:43
@EmileRolley
Copy link
Author

EmileRolley commented Jun 24, 2021

There is some display issues with LaTex expressions:

Screenshot from 2021-06-24 19-44-38

@yurug is it normal or should they be removed?

@yurug
Copy link
Contributor

yurug commented Jul 14, 2021

About the exercise names: we will not change them unless @acamanes agrees to. However, can you move the exercises in a subdirectory named alain.camanes please?

@yurug
Copy link
Contributor

yurug commented Jul 14, 2021

Do not worry about LaTeX part: they should be OK. There is bug to be fixed at the learn-ocaml level to reactivate MathJax.

@yurug
Copy link
Contributor

yurug commented Jul 14, 2021

Could you set up a simple CI that simply checks that learnocaml build works, please?

@EmileRolley
Copy link
Author

About the exercise names: we will not change them unless @acamanes agrees to.

Do you mean keeping all exercises under only one group ? @yurug

@EmileRolley
Copy link
Author

EmileRolley commented Jul 14, 2021

Could you set up a simple CI that simply checks that learnocaml build works, please?

Done here: #4 @yurug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants