feat(server): add a --replace option
#567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikmd
added
kind: feature
Closes ocaml-sf#529 which seemed to be a common complaint among teachers. * `learn-ocaml serve --replace` will kill an existing server (running on the same port) just before starting * `learn-ocaml build serve` with an existing server on the same port will fail fast (before actually doing the build) * `learn-ocaml build serve --replace` is more clever: - it will do the build *in a temporary directory* - then, only if everything is ok, kill the older server - swap the files and start the new server This is all done in order to minimise downtime and be convenient for server updates. Note that this PR sits on top of ocaml-sf#481 and should be rebased once it's merged.
This makes it easier to identify problem when one exercise is misbehaving (see ocaml-sf/learn-ocaml-corpus@b6e1f61)
AltGr
removed
the
needs: merge of dependency
|
Thanks @AltGr, this enhancement is a must-have !! I didn't finish my tests yet, but as I told you by e-mail I expect this to be done on this Monday Nov 20. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #529 which seemed to be a common complaint among teachers.
learn-ocaml serve --replacewill kill an existing server (running on thesame port) just before starting
learn-ocaml build servewith an existing server on the same port will failfast (before actually doing the build)
learn-ocaml build serve --replaceis more clever:This is all done in order to minimise downtime and be convenient for server
updates.
Note that this PR sits on top of #481 and should be rebased once it'smerged.