Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System changes #100

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

System changes #100

wants to merge 6 commits into from

Conversation

asere
Copy link
Collaborator

@asere asere commented Mar 22, 2022 •
edited
Loading

This PR will sanitize lots of code from express routes/controllers.

Here is the tests I have done and work

  • Creating a new user
  • Deleting an user (from itself or from an admin)
  • Creating a new server
  • Managing a server (adding an archive exercises.zip, creating groups)
  • Launching a Learn-OCaml instance server
  • Checking if the instance actually work
  • Deleting a server

These tests will be done from an user and from an admin:

  • Changing a password
  • Disable / activate an user
  • Authorize an user
  • Stopping a server
  • Downloading a server
  • Generate and retrieving a teacher token

@asere
linting the new files + no-fallthrough rule edited
d09f919 
update typescript to 4.5.4
update all eslint packages
adding nodejs debugger !
better utils/Data file
updating to abstract class CloudService
@asere
adding own archive service
d51132a 
cleaning upload controller
partial lint of src/controllers/upload.ts
removed useless variable in server-settings in Frontend
removing packages:
 - archiver
 - child_process
 - express-session & @types
 - fs-readdir-recursive
 - fs-extra
 - rimraf
 - unzipper
@asere
fix user deletion does not purge jwt if user is self deleting as admin
2ff3172 
fix most of express response sendStatus call followed by json
This was linked to issues Mar 23, 2022
Sending an archive create a temporary global ".zip" file #99
Open
remove fs-extra package, write a recursive copyDir function instead #101
Open
@asere asere force-pushed the master branch 2 times, most recently from 5999f09 to 1235199 Compare August 29, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@asere