Add workaround for missing batteriesConfig dependency in inline tests #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dune clean && dune build @src/runtestdoes reproduce the error, even w/ ocaml-5.0.0 |
|
You only fixed the target batteries_unthreaded; in src/dune there is also batteries which also have this same inline_tests section. |
But that only has |
|
Ok, I see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes this issue: ocaml/opam-repository#24327 (comment).
I could reproduce it by commenting out the
teststanza insrc/duneand runningdune clean && dune build @src/runtest. After these changes that problem no longer appears for me like that, so hopefully it's also fixed for the CI.