Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Python Den level control #2345

Merged
merged 7 commits into from
Sep 5, 2024
Merged

feat: Python Den level control #2345

merged 7 commits into from
Sep 5, 2024

Conversation

faucomte97
Copy link
Contributor

@faucomte97 faucomte97 commented Sep 4, 2024

This change is Reviewable

@faucomte97 faucomte97 self-assigned this Sep 4, 2024
@faucomte97 faucomte97 linked an issue Sep 4, 2024 that may be closed by this pull request
3 tasks
@faucomte97 faucomte97 enabled auto-merge (squash) September 5, 2024 13:57
Copy link
Contributor

@evemartin evemartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes all look good! But when I logged in locally as a student and tried using the "next level" button to skip over a locked level it still sent me to that level and showed me an error page :( specifically I locked Python Den level 8 and used the next level button in level 7 - maybe the fix about the names the other day wasn't enough?

Reviewed 5 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

@faucomte97 faucomte97 merged commit 1637d51 into master Sep 5, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python Den level access control
2 participants