fix: move verification emails to Dotdigital

[evemartin]

Description

How Has This Been Tested?

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have linked this PR to a ZenHub Issue.

---

This change is 

[faucomte97]

Reviewed 6 of 13 files at r1, all commit messages.
Reviewable status: 6 of 13 files reviewed, 3 unresolved discussions (waiting on @evemartin)

---

.github/workflows/ci.yml line 12 at r1 (raw file):

    env:
      LANG: C.UTF-8
      DOTDIGITAL_AUTH: ${{ secrets.DOTDIGITAL_AUTH }}

We don't want this here, instead it should be added to app_settings.py in common - this is where the env vars from the appengine repo get pulled in.
You'll also need to add it in portal_test_settings.py so the tests can run (I think).

---

cfl_common/common/helpers/emails.py line 7 at r1 (raw file):

from uuid import uuid4

from django.urls import reverse

Please organise your imports 🙂

---

cfl_common/common/helpers/emails.py line 273 at r1 (raw file):

        users_with_email = User.objects.filter(email=new_email)

        send_dotdigital_email(1551600, [user.new_user.email], personalization_values={"NEW_EMAIL_ADDRESS": new_email})

(Check out the thread in cfl-dev-team for more info if you want) TL;DR
We want to store the campaign IDs in a central file so they are 1) reusable and 2) not scattered around in the code.
Please create a dict in mail.py where values are the campaign IDs and the keys are a string so we know which campaign the ID refers to. Then call the dict in this file (and wherever else you might need it)

[evemartin]

Reviewable status: 3 of 18 files reviewed, 3 unresolved discussions (waiting on @evemartin and @faucomte97)

---

cfl_common/common/helpers/emails.py line 7 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Please organise your imports 🙂

Done.

---

cfl_common/common/helpers/emails.py line 273 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

(Check out the thread in cfl-dev-team for more info if you want) TL;DR
We want to store the campaign IDs in a central file so they are 1) reusable and 2) not scattered around in the code.
Please create a dict in mail.py where values are the campaign IDs and the keys are a string so we know which campaign the ID refers to. Then call the dict in this file (and wherever else you might need it)

Done.

---

.github/workflows/ci.yml line 12 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

We don't want this here, instead it should be added to app_settings.py in common - this is where the env vars from the appengine repo get pulled in.
You'll also need to add it in portal_test_settings.py so the tests can run (I think).

Done.

[faucomte97]

Reviewed 3 of 13 files at r1, 12 of 12 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @evemartin)

---

portal/tests/test_independent_student.py line 273 at r2 (raw file):

        errors = page.has_login_failed("independent_student_login_form", INVALID_LOGIN_MESSAGE)
        assert page.has_login_failed("independent_student_login_form", INVALID_LOGIN_MESSAGE)
        print(errors)

Remove print 🙂

[evemartin]

Reviewable status: 15 of 20 files reviewed, 1 unresolved discussion (waiting on @evemartin and @faucomte97)

---

portal/tests/test_independent_student.py line 273 at r2 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Remove print 🙂

Removed :)

[faucomte97]

Reviewed 4 of 5 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @evemartin)

a discussion (no related file):
Run Black formatter please :)

---

[evemartin]

Reviewable status: 10 of 49 files reviewed, 1 unresolved discussion (waiting on @evemartin and @faucomte97)

a discussion (no related file):

Previously, faucomte97 (Florian Aucomte) wrote…

Run Black formatter please :)

I've run it and also removed the unused imports!

---

[faucomte97]

Reviewed 39 of 39 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @evemartin)

[faucomte97]

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @evemartin)

[evemartin]

Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @evemartin)

[evemartin]

Reviewed 2 of 13 files at r1, 7 of 12 files at r2, 1 of 5 files at r3, 39 of 39 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @evemartin)

[faucomte97]

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @evemartin)