Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change-website-logos-to-trademarked #2270

Merged
merged 4 commits into from
Mar 20, 2024

Conversation

evemartin
Copy link
Contributor

@evemartin evemartin commented Mar 13, 2024

This change is Reviewable

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @evemartin)


portal/static/portal/img/logo_cfl.png line 0 at r1 (raw file):
Let's double check with Laura regarding the change in colour pattern

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @evemartin)

Copy link
Contributor Author

@evemartin evemartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @evemartin)


portal/static/portal/img/logo_cfl.png line at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Let's double check with Laura regarding the change in colour pattern

After double checking I have changed the logo to the version with the original colors!

@evemartin evemartin merged commit 9988e9d into master Mar 20, 2024
6 of 7 checks passed
@evemartin evemartin deleted the change-website-logos-to-trademarked branch March 20, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants