Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a button to link to Gmail on email verification #2230

Merged
merged 5 commits into from
Nov 14, 2023

Conversation

faucomte97
Copy link
Contributor

@faucomte97 faucomte97 commented Nov 8, 2023

This change is Reviewable

@faucomte97 faucomte97 self-assigned this Nov 8, 2023
Copy link
Collaborator

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @faucomte97)


portal/templates/portal/email_verification_needed.html line 13 at r1 (raw file):

    <p class="text-left">If you don't receive the email within the next few minutes, please check your spam folder.</p>
    <div>
        <a target="_blank" href="https://mail.google.com/mail/u/0/#search/from%3Ano-reply%40codeforlife.education+subject%3AEmail+Verification"

remove "u/0". This is manually selecting the first user. Rather, google should auto-select.

Copy link
Contributor Author

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @faucomte97 and @SKairinos)


portal/templates/portal/email_verification_needed.html line 13 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

remove "u/0". This is manually selecting the first user. Rather, google should auto-select.

Done.

@faucomte97 faucomte97 enabled auto-merge (squash) November 13, 2023 14:59
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #2230 (0c53449) into master (0abf196) will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2230      +/-   ##
==========================================
+ Coverage   93.97%   94.12%   +0.15%     
==========================================
  Files         170      170              
  Lines        4578     4578              
==========================================
+ Hits         4302     4309       +7     
+ Misses        276      269       -7     

see 2 files with indirect coverage changes

Copy link
Collaborator

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

@faucomte97 faucomte97 merged commit 326676d into master Nov 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants