fix: county field #2229
fix: county field #2229
Conversation
There was a problem hiding this comment.
Reviewed 20 of 20 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @SKairinos)
cfl_common/common/tests/test_models.py line 5 at r1 (raw file):
from django.utils import timezone from ..helpers.organisation import sanitise_uk_postcode
We shouldn't still need to import this, in fact you should be able to get rid of this helper altogether.
cfl_common/common/tests/test_models.py line 72 at r1 (raw file):
assert teacher3 in school.admins() def test_sanitise_uk_postcode(self):
This can be removed too
portal/static/portal/js/school.js line 5 at r1 (raw file):
$('#form-row-county').hide(); }
Extra whitespace
There was a problem hiding this comment.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @faucomte97)
cfl_common/common/tests/test_models.py line 5 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
We shouldn't still need to import this, in fact you should be able to get rid of this helper altogether.
Unfortunately, it cannot due to the way the code is currently structured. Migration 41 in common imports this helper. As a rule, migrations must never import our custom code for this very reason (it's okay for migrations to depend on 3rd party packages, like Django) - we have removed the postcode logic from the app but this postcode helper is needed by an old migration. When we restructure, we'll ensure all migrations are self contained.
cfl_common/common/tests/test_models.py line 72 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
This can be removed too
can't. see above comment about an old migration depending on this.
portal/static/portal/js/school.js line 5 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
Extra whitespace
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @SKairinos)
Codecov Report
@@ Coverage Diff @@
## master #2229 +/- ##
=======================================
Coverage 94.12% 94.12%
=======================================
Files 169 170 +1
Lines 4595 4582 -13
=======================================
- Hits 4325 4313 -12
+ Misses 270 269 -1
|
There was a problem hiding this comment.
Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status:
This change is