Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: school.country is optional #2228

Merged
merged 1 commit into from
Nov 6, 2023
Merged

fix: school.country is optional #2228

merged 1 commit into from
Nov 6, 2023

Conversation

SKairinos
Copy link
Collaborator

@SKairinos SKairinos commented Nov 6, 2023

This change is Reviewable

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)


portal/forms/organisation.py line 21 at r1 (raw file):

        help_texts = {
            "name": "Name of school or club",
            "postcode": "Postcode / Zipcode",

Just making a not here that it's weird that the postcode isn't optional when the country is, but since it's part of the second task we'll just need to make sure we don't deploy this yet until it's done.

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #2228 (3856453) into master (b8dc731) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2228      +/-   ##
==========================================
- Coverage   94.27%   94.12%   -0.15%     
==========================================
  Files         168      169       +1     
  Lines        4594     4599       +5     
==========================================
- Hits         4331     4329       -2     
- Misses        263      270       +7     
Files Coverage Δ
...mon/common/migrations/0046_alter_school_country.py 100.00% <100.00%> (ø)
cfl_common/common/models.py 89.91% <100.00%> (ø)
portal/forms/organisation.py 100.00% <100.00%> (ø)
portal/views/organisation.py 98.24% <100.00%> (ø)
portal/views/teacher/dashboard.py 95.23% <100.00%> (-1.79%) ⬇️

... and 1 file with indirect coverage changes

@SKairinos SKairinos merged commit 8cdec46 into master Nov 6, 2023
6 of 7 checks passed
@SKairinos SKairinos deleted the optional_country_field branch November 6, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants