Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Total activity table #2168

Merged
merged 3 commits into from
Sep 7, 2023
Merged

feat: Total activity table #2168

merged 3 commits into from
Sep 7, 2023

Conversation

faucomte97
Copy link
Contributor

@faucomte97 faucomte97 commented Sep 5, 2023

This change is Reviewable

@faucomte97 faucomte97 self-assigned this Sep 5, 2023
Copy link
Contributor Author

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #2168 (0db1814) into master (c7a972a) will decrease coverage by 0.08%.
Report is 2 commits behind head on master.
The diff coverage is 91.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2168      +/-   ##
==========================================
- Coverage   94.48%   94.40%   -0.08%     
==========================================
  Files         164      166       +2     
  Lines        4512     4555      +43     
==========================================
+ Hits         4263     4300      +37     
- Misses        249      255       +6     
Files Changed Coverage Δ
...ommon/common/migrations/0043_add_total_activity.py 83.33% <83.33%> (ø)
cfl_common/common/models.py 89.66% <87.50%> (-0.08%) ⬇️
portal/views/cron/user.py 90.90% <89.65%> (-3.30%) ⬇️
cfl_common/common/migrations/0042_totalactivity.py 100.00% <100.00%> (ø)
portal/__init__.py 100.00% <100.00%> (ø)
portal/admin.py 87.64% <100.00%> (+0.89%) ⬆️
portal/views/home.py 89.47% <100.00%> (+0.24%) ⬆️
portal/views/teacher/teach.py 97.07% <100.00%> (+0.01%) ⬆️

@faucomte97 faucomte97 merged commit e5153aa into master Sep 7, 2023
5 of 6 checks passed
@faucomte97 faucomte97 deleted the total_activity_model branch September 7, 2023 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant