Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: iterate over queryset #2167

Merged
merged 1 commit into from
Sep 5, 2023
Merged

fix: iterate over queryset #2167

merged 1 commit into from
Sep 5, 2023

Conversation

SKairinos
Copy link
Collaborator

@SKairinos SKairinos commented Sep 5, 2023

Description

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have linked this PR to a ZenHub Issue.

This change is Reviewable

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #2167 (3d66faa) into master (c7a972a) will increase coverage by 0.09%.
The diff coverage is 89.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2167      +/-   ##
==========================================
+ Coverage   94.48%   94.57%   +0.09%     
==========================================
  Files         164      164              
  Lines        4512     4520       +8     
==========================================
+ Hits         4263     4275      +12     
+ Misses        249      245       -4     
Files Changed Coverage Δ
portal/views/cron/user.py 90.90% <89.65%> (-3.30%) ⬇️

... and 2 files with indirect coverage changes

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

@faucomte97 faucomte97 merged commit 71a4a48 into master Sep 5, 2023
5 of 6 checks passed
@faucomte97 faucomte97 deleted the cron_iterate_queryset branch September 5, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants