Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Shorten verify email link #2166

Merged
merged 3 commits into from
Sep 1, 2023
Merged

Conversation

faucomte97
Copy link
Contributor

@faucomte97 faucomte97 commented Sep 1, 2023

This change is Reviewable

@faucomte97 faucomte97 self-assigned this Sep 1, 2023
Copy link
Collaborator

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

Copy link
Contributor Author

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #2166 (b6a02ac) into master (718667d) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2166      +/-   ##
==========================================
+ Coverage   94.47%   94.63%   +0.15%     
==========================================
  Files         164      164              
  Lines        4510     4512       +2     
==========================================
+ Hits         4261     4270       +9     
+ Misses        249      242       -7     
Files Changed Coverage Δ
portal/views/cron/user.py 94.20% <100.00%> (+0.17%) ⬆️

... and 2 files with indirect coverage changes

@faucomte97 faucomte97 merged commit 4884fbd into master Sep 1, 2023
5 checks passed
@faucomte97 faucomte97 deleted the shorten_verify_email_link branch September 1, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants