fix: Fix verify email link #2165
Conversation
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @faucomte97)
portal/views/cron/user.py line 61 at r1 (raw file):
def replace_protocol_and_app_in_link(url: str) -> str:
can we simplify this and create a helper called build_absolute_google_uri and pass in the request and location (the return value of result)
def build_absolute_google_uri(request, location):
...
There was a problem hiding this comment.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @faucomte97 and @SKairinos)
portal/views/cron/user.py line 61 at r1 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
can we simplify this and create a helper called build_absolute_google_uri and pass in the request and location (the return value of result)
def build_absolute_google_uri(request, location):
...
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @faucomte97)
Codecov Report
@@ Coverage Diff @@
## master #2165 +/- ##
==========================================
- Coverage 94.62% 94.47% -0.15%
==========================================
Files 164 164
Lines 4504 4510 +6
==========================================
- Hits 4262 4261 -1
- Misses 242 249 +7
|
This change is