feat: add cron urls for user verification

.github/workflows/ci.yml

@@ -27,8 +27,6 @@ jobs:
         run: |
           pip install pipenv
           pipenv install --dev --system
-          pip uninstall aimmo -y
-          pip install git+https://github.com/ocadotechnology/aimmo@max_games_limit#egg=aimmo
           yarn --frozen-lockfile
       - name: Build frontend
         run: |

.gitignore

@@ -25,7 +25,7 @@ example_project/static/
 codeforlife_portal.egg-info
 *.egg-info/
 build/
-.vscode/
+# .vscode/
 dist/
 node_modules
 

.vscode/launch.json

@@ -0,0 +1,29 @@
+{
+  // Use IntelliSense to learn about possible attributes.
+  // Hover to view descriptions of existing attributes.
+  // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
+  "version": "0.2.0",
+  "configurations": [
+    {
+      "name": "Django Server",
+      "type": "python",
+      "request": "launch",
+      "django": true,
+      "justMyCode": false,
+      "program": "${workspaceFolder}/example_project/manage.py",
+      "args": [
+        "runserver",
+        "localhost:8000"
+      ]
+    },
+    {
+      "name": "Pytest",
+      "type": "python",
+      "request": "test",
+      "justMyCode": false,
+      "presentation": {
+        "hidden": true
+      }
+    }
+  ]
+}

.vscode/settings.json

@@ -0,0 +1,4 @@
+{
+  "python.testing.unittestEnabled": false,
+  "python.testing.pytestEnabled": true
+}

cfl_common/common/helpers/emails.py

@@ -76,9 +76,12 @@ def generate_token(user, new_email="", preverified=False):
         user.userprofile.is_verified = preverified
         user.userprofile.save()
 
+    return generate_token_for_email(user.email, new_email)
+
+def generate_token_for_email(email: str, new_email: str = ""):
     return jwt.encode(
         {
-            "email": user.email,
+            "email": email,
             "new_email": new_email,
             "email_verification_token": uuid4().hex[:30],
             "expires": (timezone.now() + datetime.timedelta(hours=1)).timestamp(),

portal/mixins/__init__.py

@@ -0,0 +1 @@
+from .cron_mixin import CronMixin

portal/mixins/cron_mixin.py

@@ -0,0 +1,12 @@
+from rest_framework.request import Request
+from rest_framework.response import Response
+
+from ..permissions import IsCronRequestFromGoogle
+
+
+class CronMixin:
+    http_method_names = ["get"]
+    permission_classes = [IsCronRequestFromGoogle]
+
+    def get(self, request: Request) -> Response:
+        raise NotImplementedError()

portal/permissions/__init__.py

@@ -0,0 +1 @@
+from .is_cron_request_from_google import IsCronRequestFromGoogle

portal/permissions/is_cron_request_from_google.py

@@ -0,0 +1,14 @@
+from django.conf import settings
+from rest_framework.permissions import BasePermission
+from rest_framework.request import Request
+from rest_framework.views import View
+
+
+class IsCronRequestFromGoogle(BasePermission):
+    """
+    Validate that requests to your cron URLs are coming from App Engine and not from another source.
+    https://cloud.google.com/appengine/docs/flexible/scheduling-jobs-with-cron-yaml#securing_urls_for_cron
+    """
+
+    def has_permission(self, request: Request, view: View):
+        return settings.DEBUG or request.META.get("HTTP_X_APPENGINE_CRON") == "true"

portal/tests/test_views.py

@@ -2,11 +2,12 @@
 import io
 import json
 from datetime import timedelta, date
+from unittest.mock import patch, Mock, ANY
 
 import PyPDF2
 import pytest
 from aimmo.models import Game
-from common.models import Teacher, UserSession, Student, Class, DailyActivity, School
+from common.models import Teacher, UserSession, Student, Class, DailyActivity, School, UserProfile
 from common.tests.utils.classes import create_class_directly
 from common.tests.utils.organisation import create_organisation_directly, join_teacher_to_organisation
 from common.tests.utils.student import (
@@ -22,10 +23,11 @@
 from game.models import Level
 from game.tests.utils.attempt import create_attempt
 from game.tests.utils.level import create_save_level
+from rest_framework.test import APIClient, APITestCase
 
-from portal.templatetags.app_tags import is_logged_in_as_admin_teacher
-
+from cfl_common.common.helpers.emails import NOTIFICATION_EMAIL
 from deploy import captcha
+from portal.templatetags.app_tags import is_logged_in_as_admin_teacher
 from portal.views.api import anonymise
 from portal.views.teacher.teach import (
     REMINDER_CARDS_PDF_ROWS,
@@ -706,3 +708,233 @@ def test_logged_in_as_admin_check(self):
         assert not is_logged_in_as_admin_teacher(teacher2.new_user)
 
         c.logout()
+
+
+# CRON view tests
+
+
+class CronTestClient(APIClient):
+    def __init__(self, *args, **kwargs):
+        super().__init__(*args, **kwargs, HTTP_X_APPENGINE_CRON="true")
+
+    def generic(
+        self,
+        method,
+        path,
+        data="",
+        content_type="application/octet-stream",
+        secure=False,
+        **extra,
+    ):
+        wsgi_response = super().generic(method, path, data, content_type, secure, **extra)
+        assert 200 <= wsgi_response.status_code < 300, f"Response has error status code: {wsgi_response.status_code}"
+
+        return wsgi_response
+
+
+class CronTestCase(APITestCase):
+    client_class = CronTestClient
+
+
+class TestUser(CronTestCase):
+    # TODO: use fixtures
+    def setUp(self):
+        (
+            self.teacher_user,
+            self.teacher_user_profile,
+            self.indy_user,
+            self.indy_user_profile,
+            self.student_user,
+        ) = self.create_users()
+
+    def create_users(self):
+        teacher_email, _ = signup_teacher_directly(preverified=False)
+        create_organisation_directly(teacher_email)
+        _, _, access_code = create_class_directly(teacher_email)
+        _, _, student = create_school_student_directly(access_code)
+        indy_email, _, _ = create_independent_student_directly()
+
+        teacher_user = User.objects.get(email=teacher_email)
+        teacher_user_profile = UserProfile.objects.get(user=teacher_user)
+
+        indy_user = User.objects.get(email=indy_email)
+        indy_user_profile = UserProfile.objects.get(user=indy_user)
+
+        return (
+            teacher_user,
+            teacher_user_profile,
+            indy_user,
+            indy_user_profile,
+            student.new_user,
+        )
+
+    def send_verify_email_reminder(
+        self,
+        days: int,
+        is_verified: bool,
+        view_name: str,
+        send_email: Mock,
+        assert_called: bool,
+    ):
+        self.teacher_user.date_joined = timezone.now() - timedelta(days=days, hours=12)
+        self.teacher_user.save()
+        self.student_user.date_joined = timezone.now() - timedelta(days=days, hours=12)
+        self.student_user.save()
+        self.indy_user.date_joined = timezone.now() - timedelta(days=days, hours=12)
+        self.indy_user.save()
+
+        self.teacher_user_profile.is_verified = is_verified
+        self.teacher_user_profile.save()
+        self.indy_user_profile.is_verified = is_verified
+        self.indy_user_profile.save()
+
+        self.client.get(reverse(view_name))
+
+        if assert_called:
+            send_email.assert_any_call(
+                sender=NOTIFICATION_EMAIL,
+                recipients=[self.teacher_user.email],
+                subject=ANY,
+                title=ANY,
+                text_content=ANY,
+            )
+
+            send_email.assert_any_call(
+                sender=NOTIFICATION_EMAIL,
+                recipients=[self.indy_user.email],
+                subject=ANY,
+                title=ANY,
+                text_content=ANY,
+            )
+
+            # Check only two emails are sent - the student should never be included.
+            assert send_email.call_count == 2
+        else:
+            send_email.assert_not_called()
+
+        send_email.reset_mock()
+
+    @patch("portal.views.cron.user.send_email")
+    def test_first_verify_email_reminder_view(self, send_email: Mock):
+        self.send_verify_email_reminder(
+            days=6,
+            is_verified=False,
+            view_name="first-verify-email-reminder",
+            send_email=send_email,
+            assert_called=False,
+        )
+        self.send_verify_email_reminder(
+            days=7,
+            is_verified=False,
+            view_name="first-verify-email-reminder",
+            send_email=send_email,
+            assert_called=True,
+        )
+        self.send_verify_email_reminder(
+            days=7,
+            is_verified=True,
+            view_name="first-verify-email-reminder",
+            send_email=send_email,
+            assert_called=False,
+        )
+        self.send_verify_email_reminder(
+            days=8,
+            is_verified=False,
+            view_name="first-verify-email-reminder",
+            send_email=send_email,
+            assert_called=False,
+        )
+
+    @patch("portal.views.cron.user.send_email")
+    def test_second_verify_email_reminder_view(self, send_email: Mock):
+        self.send_verify_email_reminder(
+            days=13,
+            is_verified=False,
+            view_name="second-verify-email-reminder",
+            send_email=send_email,
+            assert_called=False,
+        )
+        self.send_verify_email_reminder(
+            days=14,
+            is_verified=False,
+            view_name="second-verify-email-reminder",
+            send_email=send_email,
+            assert_called=True,
+        )
+        self.send_verify_email_reminder(
+            days=14,
+            is_verified=True,
+            view_name="second-verify-email-reminder",
+            send_email=send_email,
+            assert_called=False,
+        )
+        self.send_verify_email_reminder(
+            days=15,
+            is_verified=False,
+            view_name="second-verify-email-reminder",
+            send_email=send_email,
+            assert_called=False,
+        )
+
+    def test_delete_unverified_accounts_view(self):
+        def delete_unverified_users(
+            days: int,
+            is_verified: bool,
+            assert_exists: bool,
+        ):
+            (
+                teacher_user,
+                teacher_user_profile,
+                indy_user,
+                indy_user_profile,
+                student_user,
+            ) = self.create_users()
+
+            teacher_user.date_joined = timezone.now() - timedelta(days=days, hours=12)
+            teacher_user.save()
+            student_user.date_joined = timezone.now() - timedelta(days=days, hours=12)
+            student_user.save()
+            indy_user.date_joined = timezone.now() - timedelta(days=days, hours=12)
+            indy_user.save()
+
+            teacher_user_profile.is_verified = is_verified
+            teacher_user_profile.save()
+            indy_user_profile.is_verified = is_verified
+            indy_user_profile.save()
+
+            self.client.get(reverse("delete-unverified-accounts"))
+
+            teacher_user_exists = User.objects.filter(id=teacher_user.id).exists()
+            indy_user_exists = User.objects.filter(id=indy_user.id).exists()
+            student_user_exists = User.objects.filter(id=student_user.id).exists()
+            (self.assertTrue if assert_exists else self.assertFalse)(teacher_user_exists)
+            (self.assertTrue if assert_exists else self.assertFalse)(indy_user_exists)
+            self.assertTrue(student_user_exists)
+
+            if teacher_user_exists:
+                teacher_user.delete()
+            if indy_user_exists:
+                indy_user.delete()
+            if student_user_exists:
+                student_user.delete()
+
+        delete_unverified_users(
+            days=18,
+            is_verified=False,
+            assert_exists=True,
+        )
+        delete_unverified_users(
+            days=19,
+            is_verified=False,
+            assert_exists=False,
+        )
+        delete_unverified_users(
+            days=19,
+            is_verified=True,
+            assert_exists=True,
+        )
+        delete_unverified_users(
+            days=20,
+            is_verified=False,
+            assert_exists=False,
+        )