Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update how Kurono games are created #2153

Merged
merged 4 commits into from
Jul 27, 2023
Merged

fix: Update how Kurono games are created #2153

merged 4 commits into from
Jul 27, 2023

Conversation

faucomte97
Copy link
Contributor

@faucomte97 faucomte97 commented Jul 27, 2023

This change is Reviewable

@faucomte97 faucomte97 self-assigned this Jul 27, 2023
Copy link
Contributor

@cewei8483 cewei8483 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #2153 (a4dd68b) into master (43980e9) will increase coverage by 0.15%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2153      +/-   ##
==========================================
+ Coverage   94.46%   94.62%   +0.15%     
==========================================
  Files         155      155              
  Lines        4374     4372       -2     
==========================================
+ Hits         4132     4137       +5     
+ Misses        242      235       -7     
Files Changed Coverage Δ
portal/views/aimmo/dashboard.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@faucomte97 faucomte97 merged commit 7596342 into master Jul 27, 2023
5 checks passed
@faucomte97 faucomte97 deleted the max_games_limit branch July 27, 2023 14:07
faucomte97 added a commit that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants