Portal frontend 5

[SKairinos]

This change is 

[faucomte97]

Reviewed 36 of 36 files at r1, all commit messages.
Reviewable status: all files reviewed, 8 unresolved discussions (waiting on @SKairinos)

---

package.json line 26 at r1 (raw file):

  ],
  "dependencies": {
    "codeforlife": "github:ocadotechnology/codeforlife-package-javascript#portal-frontend-5",

New package

---

src/pages/privacyNotice/adults/Changes.tsx line 9 at r1 (raw file):

  <>
    <Typography>
      This Privacy Notice was last updated on 25th January 2023.

Wrong date. Ideally we have the last_updated date stored somewhere so we just change it in 1 spot and it updates it everywhere it's used.

---

src/pages/privacyNotice/adults/ContactUs.tsx line 11 at r1 (raw file):

    <Typography mb={0}>
      Please contact our Data Protection Officer or us at&nbsp;
      <Link to="mailto:[email protected]" target="_blank">

I don't think target="_blank" applies to mailto links

---

src/pages/privacyNotice/adults/YourRights.tsx line 64 at r1 (raw file):

      <ListItemText>
        email our Data Protection Officer at&nbsp;
        <Link to="mailto:[email protected]" target="_blank">

Same comment as before

---

src/pages/privacyNotice/children/Children.tsx line 42 at r1 (raw file):

      to identify you, such as your name and email address.
    </Typography>
    <TableOfContents

The children's version doesn't have a table of contents (I think that was done to make it less confusing for kids), we should probably remove it from here.

---

src/pages/privacyNotice/children/HowToComplain.tsx line 12 at r1 (raw file):

      If you have a complaint about how we’ve used your personal information,
      you can write to our Data Protection Officer at 
      <Link to="mailto:[email protected]" target="_blank">

Same as above

---

src/pages/privacyNotice/children/HowToComplain.tsx line 23 at r1 (raw file):

      ICO by telephoning them on the number below or by visiting their website.
    </Typography>
    <Typography>Telephone: 0303 123 1113</Typography>

Update this to also have +44 like in the main adult notice

---

src/pages/privacyNotice/children/YourRights.tsx line 42 at r1 (raw file):

      If you would like to use any of these rights listed above, please email
      our Data Protection Officer at 
      <Link to="mailto:[email protected]" target="_blank">

Same as above

[SKairinos]

Reviewable status: 31 of 36 files reviewed, 8 unresolved discussions (waiting on @faucomte97)

---

package.json line 26 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

New package

Done.

---

src/pages/privacyNotice/adults/Changes.tsx line 9 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Wrong date. Ideally we have the last_updated date stored somewhere so we just change it in 1 spot and it updates it everywhere it's used.

Done.

---

src/pages/privacyNotice/adults/ContactUs.tsx line 11 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

I don't think target="_blank" applies to mailto links

It does. It's a browser tab like any other.

---

src/pages/privacyNotice/adults/YourRights.tsx line 64 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Same comment as before

It does. It's a browser tab like any other.

---

src/pages/privacyNotice/children/Children.tsx line 42 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

The children's version doesn't have a table of contents (I think that was done to make it less confusing for kids), we should probably remove it from here.

Got approval from Laura to add this on the 1st iteration of the portal-react.

---

src/pages/privacyNotice/children/HowToComplain.tsx line 12 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Same as above

It does. It's a browser tab like any other.

---

src/pages/privacyNotice/children/HowToComplain.tsx line 23 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Update this to also have +44 like in the main adult notice

Done.

---

src/pages/privacyNotice/children/YourRights.tsx line 42 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Same as above

It does. It's a browser tab like any other.

[faucomte97]

Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @SKairinos)

---

src/pages/privacyNotice/adults/ContactUs.tsx line 11 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

It does. It's a browser tab like any other.

Is it?

---

src/pages/privacyNotice/children/HowToComplain.tsx line 12 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

It does. It's a browser tab like any other.

Is it?

[faucomte97]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)