-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Portal frontend 51 #61
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 17 of 17 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @SKairinos)
package.json
line 26 at r1 (raw file):
], "dependencies": { "codeforlife": "github:ocadotechnology/codeforlife-package-javascript#portal-frontend-51",
Install new package
src/pages/teacherDashboard/classes/class/UpdateStudentUser.tsx
line 63 at r1 (raw file):
<forms.Form initialValues={{ id: studentUserId, first_name: user.first_name }} onSubmit={submitForm(updateUser, {
Sanity check. Does the backend check whether or not the name we're updating it to already exists in the class & does it spit out an error message in this form?
Current site:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 15 of 17 files reviewed, 2 unresolved discussions (waiting on @faucomte97)
package.json
line 26 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
Install new package
Done.
src/pages/teacherDashboard/classes/class/UpdateStudentUser.tsx
line 63 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
Sanity check. Does the backend check whether or not the name we're updating it to already exists in the class & does it spit out an error message in this form?
Current site:
It does now - I added it. Good shout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)
This change is