Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portal frontend 25 #30

Merged
merged 19 commits into from
Aug 13, 2024
Merged

Portal frontend 25 #30

merged 19 commits into from
Aug 13, 2024

Conversation

SKairinos
Copy link
Contributor

@SKairinos SKairinos commented Aug 9, 2024

This change is Reviewable

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @SKairinos)


src/pages/studentDashboard/Games.tsx line 16 at r1 (raw file):

    <Stack spacing={4} alignItems="center">
      <Typography variant="h4" textAlign="center">
        Your {isStudent && "class"} games

I say we get rid of this difference. Let's just have "Your games" for both user types (especially now that Kurono is gone)


src/pages/studentDashboard/RapidRouterProgress.tsx line 46 at r1 (raw file):

        style={{ marginTop: 20 }}
        endIcon={<ChevronRightIcon />}
        href={paths.rapidRouter._}

Add TODO to link to scoreboard path (not just RR base path)

Copy link
Contributor Author

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 8 of 10 files reviewed, 2 unresolved discussions (waiting on @faucomte97)


src/pages/studentDashboard/Games.tsx line 16 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

I say we get rid of this difference. Let's just have "Your games" for both user types (especially now that Kurono is gone)

Done. Agreed.


src/pages/studentDashboard/RapidRouterProgress.tsx line 46 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Add TODO to link to scoreboard path (not just RR base path)

Done.

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

@SKairinos SKairinos merged commit a1baf2d into development Aug 13, 2024
8 of 9 checks passed
@SKairinos SKairinos deleted the portal-frontend-25 branch August 13, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants