About us page

[faucomte97]

This change is 

[SKairinos]

Reviewed 23 of 23 files at r1, all commit messages.
Reviewable status: all files reviewed, 13 unresolved discussions (waiting on @faucomte97)

---

.env line 12 at r1 (raw file):

VITE_LINK_OUTLOOK_HOME=https://outlook.live.com/mail/
VITE_LINK_SKILLS_FOR_THE_FUTURE=https://www.ocadogroup.com/sustainability/sustainability/
VITE_LINK_PORTAL_GITHUB_HREF=https://github.com/ocadotechnology/codeforlife-portal

no need to append key with HREF since it's already prepended with LINK

---

.env line 13 at r1 (raw file):

VITE_LINK_SKILLS_FOR_THE_FUTURE=https://www.ocadogroup.com/sustainability/sustainability/
VITE_LINK_PORTAL_GITHUB_HREF=https://github.com/ocadotechnology/codeforlife-portal
VITE_LINK_CFL_DOCS_HREF=https://docs.codeforlife.education/

no need to append key with HREF since it's already prepended with LINK

---

src/pages/aboutUs/AboutUs.tsx line 16 at r1 (raw file):

const AboutUs: FC<AboutUsProps> = () => {
  const theme = useTheme()

delete this

---

src/pages/aboutUs/AboutUs.tsx line 34 at r1 (raw file):

        <Statistics />
      </page.Section>
      <page.Section boxProps={{ bgcolor: theme.palette.info.main }}>

use short hand bgcolor: "info.main"

---

src/pages/aboutUs/AboutUs.tsx line 40 at r1 (raw file):

        <OcadoGroup />
      </page.Section>
      <page.Section boxProps={{ bgcolor: theme.palette.info.main }}>

use short hand bgcolor: "info.main"

---

src/pages/aboutUs/AboutUs.tsx line 46 at r1 (raw file):

        <Supporters />
      </page.Section>
      <page.Section boxProps={{ bgcolor: theme.palette.info.main }}>

use short hand bgcolor: "info.main"

---

src/pages/aboutUs/Quotes.tsx line 4 at r1 (raw file):

import { type FC } from "react"

export interface QuoteProps {

don't export this since we're not exporting Quote. Can also define the props directly in FC if you want.

---

src/pages/aboutUs/Statistics.tsx line 4 at r1 (raw file):

import { type FC } from "react"

export interface StatisticProps {

don't export this since we're not exporting Statistic. Can also define the props directly in FC if you want.

---

src/pages/aboutUs/Supporters.tsx line 4 at r1 (raw file):

import { type FC } from "react"

import { Image } from "codeforlife/components"

import should be with above import group

---

src/pages/aboutUs/Supporters.tsx line 15 at r1 (raw file):

import PressureCookerImage from "../../images/pressure_cooker_logo.png"

export interface SupporterProps {

see previous comment. don't export

---

src/pages/aboutUs/Supporters.tsx line 56 at r1 (raw file):

            To contribute, head over to{" "}
            <Link
              href={import.meta.env.VITE_LINK_PORTAL_GITHUB_HREF}

now that we've improved our docs, this should link to https://docs.codeforlife.education/become-a-contributor

---

src/pages/aboutUs/Supporters.tsx line 56 at r1 (raw file):

            To contribute, head over to{" "}
            <Link
              href={import.meta.env.VITE_LINK_PORTAL_GITHUB_HREF}

use to property, not href

---

src/pages/aboutUs/Supporters.tsx line 67 at r1 (raw file):

            find more info about how to do all these on our{" "}
            <Link
              href={import.meta.env.VITE_LINK_CFL_DOCS_HREF}

use to property, not href

[faucomte97]

Reviewable status: all files reviewed, 13 unresolved discussions (waiting on @SKairinos)

---

.env line 12 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

no need to append key with HREF since it's already prepended with LINK

Done.

---

.env line 13 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

no need to append key with HREF since it's already prepended with LINK

Done.

---

src/pages/aboutUs/AboutUs.tsx line 16 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

delete this

Done.

---

src/pages/aboutUs/AboutUs.tsx line 34 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

use short hand bgcolor: "info.main"

Done.

---

src/pages/aboutUs/AboutUs.tsx line 40 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

use short hand bgcolor: "info.main"

Done.

---

src/pages/aboutUs/AboutUs.tsx line 46 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

use short hand bgcolor: "info.main"

Done.

---

src/pages/aboutUs/Quotes.tsx line 4 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

don't export this since we're not exporting Quote. Can also define the props directly in FC if you want.

Done.

---

src/pages/aboutUs/Statistics.tsx line 4 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

don't export this since we're not exporting Statistic. Can also define the props directly in FC if you want.

Done.

---

src/pages/aboutUs/Supporters.tsx line 4 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

import should be with above import group

Done.

---

src/pages/aboutUs/Supporters.tsx line 15 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

see previous comment. don't export

Done.

---

src/pages/aboutUs/Supporters.tsx line 56 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

now that we've improved our docs, this should link to https://docs.codeforlife.education/become-a-contributor

Done.

---

src/pages/aboutUs/Supporters.tsx line 56 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

use to property, not href

Done.

---

src/pages/aboutUs/Supporters.tsx line 67 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

use to property, not href

Done.

[SKairinos]

Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @faucomte97)

---

src/pages/aboutUs/Supporters.tsx line 56 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Done.

why did you delete the color and underline props?

---

src/pages/aboutUs/Supporters.tsx line 67 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Done.

why did you delete the color and underline props?

---

src/pages/aboutUs/Supporters.tsx line 3 at r2 (raw file):

import {
  Unstable_Grid2 as Grid,
  Link as MuiLink,

don't use MuiLink, just use our Link

[faucomte97]

Reviewable status: 22 of 23 files reviewed, 3 unresolved discussions (waiting on @SKairinos)

---

src/pages/aboutUs/Supporters.tsx line 56 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

why did you delete the color and underline props?

Because none of the other Links we use have those props so I assume we don't want them

---

src/pages/aboutUs/Supporters.tsx line 67 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

why did you delete the color and underline props?

Because none of the other Links we use have those props so I assume we don't want them

---

src/pages/aboutUs/Supporters.tsx line 3 at r2 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

don't use MuiLink, just use our Link

Done.

[SKairinos]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @faucomte97)

---

src/pages/aboutUs/Supporters.tsx line 56 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Because none of the other Links we use have those props so I assume we don't want them

In this case we do. Otherwise the text would like normal typography, not a link. (see on the old site)

---

src/pages/aboutUs/Supporters.tsx line 67 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Because none of the other Links we use have those props so I assume we don't want them

In this case we do. Otherwise the text would like normal typography, not a link. (see on the old site)

[SKairinos]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @faucomte97)

---

src/pages/aboutUs/Supporters.tsx line 56 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

In this case we do. Otherwise the text would like normal typography, not a link. (see on the old site)

*would look like

---

src/pages/aboutUs/Supporters.tsx line 67 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

In this case we do. Otherwise the text would like normal typography, not a link. (see on the old site)

*would look like

[faucomte97]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @SKairinos)

---

src/pages/aboutUs/Supporters.tsx line 56 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

*would look like

No, they still have the underline

---

src/pages/aboutUs/Supporters.tsx line 67 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

*would look like

[SKairinos]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)