Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portal frontend#12 #13

Merged
merged 22 commits into from
Jul 16, 2024
Merged

Portal frontend#12 #13

merged 22 commits into from
Jul 16, 2024

Conversation

SKairinos
Copy link
Contributor

@SKairinos SKairinos commented Jul 15, 2024

This change is Reviewable

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 20 of 20 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @SKairinos)


src/components/NewPasswordField.tsx line 26 at r1 (raw file):

    teacher: teacherPasswordSchema,
    independent: indyPasswordSchema,
    student: studentPasswordSchema,

Do we need this in the end, since we're not checking anything? (or are we leaving it for future use, ie for the set password views)


src/pages/resetPassword/EmailForm.tsx line 25 at r1 (raw file):

        If you have entered a valid email address, you will receive a link
        enabling you to reset your password.
      </Typography>

Update this - needs newer text, icon also comes after the text not before.

Plus also add the open in Gmail and Outlook buttons

Code quote:

      <SendIcon color="white" sx={{ fontSize: "100px", marginY: 5 }} />
      <Typography>
        If you have entered a valid email address, you will receive a link
        enabling you to reset your password.
      </Typography>

Copy link
Contributor Author

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 17 of 23 files reviewed, 2 unresolved discussions (waiting on @faucomte97)


src/components/NewPasswordField.tsx line 26 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Do we need this in the end, since we're not checking anything? (or are we leaving it for future use, ie for the set password views)

we do need this because the password's schema changes depending on the user's type. We are using it to check the strength of the password the user enters.


src/pages/resetPassword/EmailForm.tsx line 25 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Update this - needs newer text, icon also comes after the text not before.

Plus also add the open in Gmail and Outlook buttons

Done.

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

@SKairinos SKairinos merged commit 1ba4909 into development Jul 16, 2024
8 of 9 checks passed
@SKairinos SKairinos deleted the portal-frontend#12 branch July 16, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants