Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portal frontend#8 #10

Merged
merged 13 commits into from
Jul 12, 2024
Merged

Portal frontend#8 #10

merged 13 commits into from
Jul 12, 2024

Conversation

SKairinos
Copy link
Contributor

@SKairinos SKairinos commented Jul 9, 2024

This change is Reviewable

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 28 of 30 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SKairinos)


src/pages/home/AboutUs.tsx line 61 at r2 (raw file):

    <Column img={{ alt: "earth", src: GlobeIcon }}>
      <Typography textAlign="center">
        Code for Life has over 350,000 registered users across the world.

Please add TODO to update with more accurate figure.

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

@SKairinos SKairinos merged commit 57003fe into development Jul 12, 2024
3 of 5 checks passed
@SKairinos SKairinos deleted the portal-frontend#8 branch July 12, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants