api interface

[SKairinos]

This change is 

[SKairinos]

Reviewable status: 0 of 15 files reviewed, 1 unresolved discussion

---

package.json line 23 at r1 (raw file):

  "dependencies": {
    "@reduxjs/toolkit": "^2.0.1",
    "codeforlife": "github:ocadotechnology/codeforlife-package-javascript#fix_api_types",

install new version

[SKairinos]

Reviewable status: 0 of 15 files reviewed, 2 unresolved discussions

---

src/api/teacher.ts line 33 at r1 (raw file):

    removeTeacherFromSchool: build.mutation<
      UpdateResult<Teacher, "user">,
      Teacher["id"]

UpdateArg

[faucomte97]

Reviewed 11 of 15 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @SKairinos)

---

src/api/klass.ts line 26 at r2 (raw file):

        Class,
        "name" | "read_classmates_data",
        "teacher" | "receive_requests_until"

Wanted to double check if receive_requests_until is in fact a required arg for creating a class. It looks like it is in the serializer, but are we planning to require teachers to provide this setting when creating a class? Default value currently is just "never" / "off"

---

src/api/schoolTeacherInvitation.ts line 50 at r2 (raw file):

    >({
      query: ([id, body]) => ({
        url: buildUrl(detailUrl, { url: { id } }),

add /accept

---

src/api/schoolTeacherInvitation.ts line 61 at r2 (raw file):

    >({
      query: id => ({
        url: buildUrl(detailUrl, { url: { id } }),

add /reject

---

src/api/user.ts line 52 at r2 (raw file):

      }),
    }),
    verifyEmailAddress: build.mutation<

should this invalidate tags too?

[SKairinos]

Reviewable status: 13 of 15 files reviewed, 5 unresolved discussions (waiting on @faucomte97)

---

src/api/klass.ts line 26 at r2 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Wanted to double check if receive_requests_until is in fact a required arg for creating a class. It looks like it is in the serializer, but are we planning to require teachers to provide this setting when creating a class? Default value currently is just "never" / "off"

It's not required though?

---

src/api/schoolTeacherInvitation.ts line 50 at r2 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

add /accept

Done.

---

src/api/schoolTeacherInvitation.ts line 61 at r2 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

add /reject

Done.

---

src/api/user.ts line 52 at r2 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

should this invalidate tags too?

I don't think so.
When you list or retrieve users, they won't be included/excluded from the queryset depending on whether they have verified or not.

[faucomte97]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions

[faucomte97]

Reviewable status: all files reviewed, 1 unresolved discussion