Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoint definitions #8

Merged
merged 18 commits into from
Sep 2, 2024
Merged

Endpoint definitions #8

merged 18 commits into from
Sep 2, 2024

Conversation

SalmanAsh
Copy link
Contributor

@SalmanAsh SalmanAsh commented Aug 28, 2024

This change is Reviewable

@SalmanAsh SalmanAsh self-assigned this Aug 28, 2024
@SalmanAsh SalmanAsh linked an issue Aug 28, 2024 that may be closed by this pull request
Copy link

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 17 of 21 files at r1, all commit messages.
Reviewable status: 17 of 21 files reviewed, all discussions resolved (waiting on @SalmanAsh)

Copy link

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 21 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SalmanAsh)


src/pages/agreementSignatureDetails/AgreementSignatureDetails.tsx line 1 at r1 (raw file):

import * as pages from "codeforlife/components/page"

If this page (and the other 3) were for testing purposes, please remove them from this PR.

Copy link
Contributor Author

@SalmanAsh SalmanAsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 17 of 21 files reviewed, 1 unresolved discussion (waiting on @faucomte97)


src/pages/agreementSignatureDetails/AgreementSignatureDetails.tsx line 1 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

If this page (and the other 3) were for testing purposes, please remove them from this PR.

Done.

faucomte97
faucomte97 previously approved these changes Sep 2, 2024
Copy link

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SalmanAsh)

Copy link

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SalmanAsh)

@SalmanAsh SalmanAsh merged commit 3db39ca into development Sep 2, 2024
7 checks passed
@SalmanAsh SalmanAsh deleted the endpoint-definitions branch September 3, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create endpoints definitions
2 participants