-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Endpoint definitions #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 17 of 21 files at r1, all commit messages.
Reviewable status: 17 of 21 files reviewed, all discussions resolved (waiting on @SalmanAsh)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 21 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SalmanAsh)
src/pages/agreementSignatureDetails/AgreementSignatureDetails.tsx
line 1 at r1 (raw file):
import * as pages from "codeforlife/components/page"
If this page (and the other 3) were for testing purposes, please remove them from this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 17 of 21 files reviewed, 1 unresolved discussion (waiting on @faucomte97)
src/pages/agreementSignatureDetails/AgreementSignatureDetails.tsx
line 1 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
If this page (and the other 3) were for testing purposes, please remove them from this PR.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SalmanAsh)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SalmanAsh)
This change is