add agreement page details

ocadotechnology · Sep 4, 2024 · f5155bf · f5155bf
1 parent 35e75b9
commit f5155bf
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 120 deletions.
diff --git a/src/api/agreementSignature.ts b/src/api/agreementSignature.ts
@@ -51,7 +51,7 @@ export type CreateAgreementSignatureArg = CreateArg<
 export type CheckSignedAgreementSignatureResult =
   | { latest_commit_id: string; status: 404 | 451 }
   | { status: 200 }
-export type CheckSignedAgreementSignatureArg = { contributor_pk: number }
+export type CheckSignedAgreementSignatureArg = null
 
 const agreementSignatureApi = api.injectEndpoints({
   endpoints: build => ({
@@ -90,13 +90,8 @@ const agreementSignatureApi = api.injectEndpoints({
       CheckSignedAgreementSignatureResult,
       CheckSignedAgreementSignatureArg
     >({
-      query: ({ contributor_pk }) => ({
-        url: buildUrl(
-          agreementSignatureUrls.list + `check-signed/${contributor_pk}`,
-          {
-            url: { contributor_pk },
-          },
-        ),
+      query: () => ({
+        url: agreementSignatureUrls.list,
         method: "GET",
       }),
     }),

diff --git a/src/pages/agreementSignatureDetails/AgreementSignatureDetails.tsx b/src/pages/agreementSignatureDetails/AgreementSignatureDetails.tsx
@@ -44,10 +44,20 @@ const AgreementSignatureDetail: FC<AgreementSignatureDetailProps> = () => {
               <Typography variant="h6">
                 signed at: {agreementSignature.signed_at.toString()}
               </Typography>
+              <Link
+                className="button"
+                to={`https://raw.githubusercontent.com/ocadotechnology/codeforlife-workspace/${agreementSignature.agreement_id}/CONTRIBUTING.md`}
+              >
+                View Agreement
+              </Link>
             </Stack>
           </pages.Section>
           <pages.Section>
-            <Link className="back-to" to={paths.agreementSignatures._}>
+            <Link
+              target="blank"
+              className="back-to"
+              to={paths.agreementSignatures._}
+            >
               Agreement signature list
             </Link>
           </pages.Section>

diff --git a/src/pages/agreementSignatureList/AgreementSignatureList.tsx b/src/pages/agreementSignatureList/AgreementSignatureList.tsx
@@ -13,7 +13,7 @@ const AgreementSignatureList: FC<AgreementSignatureListProps> = () => {
   return (
     <pages.Page>
       <pages.Section>
-        <Typography variant="h1">Agreement Signature List</Typography>
+        <Typography variant="h1"> Your agreement signatures</Typography>
         <TablePagination
           useLazyListQuery={useLazyListAgreementSignaturesQuery}
           preferCacheValue

diff --git a/src/pages/contributorDetail/ContributorDetail.tsx b/src/pages/contributorDetail/ContributorDetail.tsx
diff --git a/src/pages/contributorList/ContributorList.tsx b/src/pages/contributorList/ContributorList.tsx