UI: Fix missing support for portable configuration files #11300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatTheMav
added
Bug Fix
PatTheMav
force-pushed
the
portable-config-fix
branch
2 times, most recently
from
9e58c78
to
5ade18d
Compare
PatTheMav
commented
Sep 19, 2024
Windows and Linux allow the storage of configuration files relative to the binary location, which is enabled by default on Windows and has to be explicitly enabled on Linux. This was originally conflated with the LINUX_PORTABLE build setting which also allowed the application itself to be run from non-default locations on a Linux system. This change reintroduces the functionality behind the ENABLE_PORTABLE_CONFIG build setting on Linux. It also adds necessary code to make this setting compatible with the recently introduced relocatable settings code changes: When portable mode is enabled, user configuration, scene collections, and profiles are stored in the config directory created for portable mode.
PatTheMav
force-pushed
the
portable-config-fix
branch
from
5ade18d
to
147eb88
Compare
|
Shouldn't this be on by default on Windows? Or does Windows always have this on? |
Correct, it’s always enabled on Windows. The explicit build flag is only needed if |
Lain-B
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes broken support for portable mode on Linux and Windows.
Motivation and Context
Windows and Linux allow the storage of configuration files relative to the binary location, which is enabled by default on Windows and has to be explicitly enabled on Linux.
This was originally conflated with the
LINUX_PORTABLEbuild setting which also allowed the application itself to be run from non-default locations on a Linux system.This change reintroduces the functionality behind the
ENABLE_PORTABLE_CONFIGbuild setting on Linux.It also adds necessary code to make this setting compatible with the recently introduced relocatable settings code changes:
When portable mode is enabled, user configuration, scene collections, and profiles are stored in the config directory created for portable mode.
How Has This Been Tested?
Tested on Windows 11 with portable mode enabled and disabled and observed configuration files being created in different respective locations.
Types of changes
Checklist: