-
-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Change clip level to 0.0 dB #11230
base: master
Are you sure you want to change the base?
Conversation
Right now it affects only input meter (small rectangle). |
Fixed the code now, so the clip level affects both the input and output meters. |
The clip level variable would only affect the input meters not the output meters.
This changes the clip level of the volume meters from -0.5 dB to 0.0 dB.
Hi all, I have a rebased copy of this PR's commits, in case it saves anyone the time/tedium. Feel free to grab from there if it's helpful. (If not, apologies for the noise.) Best regards. master...DeeDeeG:obs-studio:cg2121_clip-level_PR11230_rebased Rebase was a little involved due to #9407 landing. One line originally in this PR has already been done separately in another PR, which has already landed on P.S. works well for me, audio from a game mastered to full scale volume no longer indicates clipping during loud sounds. Just red as it should. EDIT to clarify: I meant that fixing the merge conflict was somewhat difficult/tedious, but unless I missed something, the diff looks effectively identical on my branch vs this PR. Only the line that was done separately as #11209 is not necessary anymore and disappears when rebasing, as it is 100% redundant -- the same line is already landed verbatim at So, now that it's done, the resulting diff looks clean and simple. If it's done right, it should match this original PR. Which I believe it does. Other than the one-line change already in I hope my rebase can either be cherry-picked to save time, or else ignored and redone by hand if reviewing my copy constitutes a distraction. Thanks for your understanding, and sorry if it adds any confusion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with this on a conceptual level. The rebased PR above will need to be looked at
Description
This changes the clip level of the volume meters from -0.5 dB to 0.0 dB.
Motivation and Context
I think the original intention was to tell users they had too loud of audio without actually clipping the audio. But if audio was intended to be this high of level, such as music, it would show it was clipping without it actually clipping.
Brought up by @PatTheMav off thread.
How Has This Been Tested?
Tested audio with a high dB level, but not clipping, to make sure the volume controls didn't show the clipping indicators.
Types of changes
Checklist: