Added morphology and related traits #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ar-ibrahim
commented
Feb 9, 2023
•
ar-ibrahim
commented
- mapping issue EFO-OBA mapping (morphology and related traits) #213
- created 16 new OBA terms mapped to EFO measurement terms
- mapped 9 EFO terms to existing OBA terms
- mapping issue #213
rays22
requested changes
Feb 10, 2023
src/mappings/oba-efo.sssom.tsv
Outdated
| EFO:0008594 vldl particle size measurement measurement skos:exactMatch OBA:2050114 HumanCurated EFO OBA 1 2023-02-09 orcid:0000-0001-6757-4744 | ||
| EFO:0008592 hdl particle size measurement measurement skos:exactMatch OBA:2050115 HumanCurated EFO OBA 1 2023-02-09 orcid:0000-0001-6757-4744 | ||
| EFO:0007117 carotid artery intima media thickness measurement skos:broadMatch OBA:2050108 HumanCurated EFO OBA 1 2023-02-09 orcid:0000-0001-6757-4744 |
There was a problem hiding this comment.
Please, remove thissrc/mappings/oba-efo.sssom.tsv version from the PR, because this version of the table has fewer lines than the OBA Ontology Development (GWAS, EFO, VT) gsheet.
Did you follow the 'Updating SSSOM mapping files' section of the Local development workflows with OBA?
This tsv should agree with the OBA Ontology Development (GWAS, EFO, VT) gsheet, but it does not.
| OBA:2050102 heart wall thickness UBERON:0037144 wall of heart PATO:0000915 thickness | ||
| OBA:2050103 hip bone size UBERON:0008202 bone of hip region PATO:0000117 size | ||
| OBA:2050104 ganglion thickness UBERON:0000045 ganglion PATO:0000915 thickness | ||
| OBA:2050105 cranial vault morphology trait UBERON:0004339 vault of skull PATO:0000051 morphology |
There was a problem hiding this comment.
Suggested change
| OBA:2050105 cranial vault morphology trait UBERON:0004339 vault of skull PATO:0000051 morphology |
There is already a term OBA:VT0000076 that has the same logical definition, so please drop OBA:2050105 from the table.
| @@ -4167,6 +4167,22 @@ OBA:2040170 GO:0030431 sleep PATO:0000001 quality | |||
| OBA:2040171 sleep duration trait GO:0030431 sleep PATO:0001309 duration | |||
| OBA:2040172 GO:0030431 sleep PATO:0001005 latency | |||
| OBA:2040173 GO:0030431 sleep PATO:0002325 onset quality | |||
| OBA:2050100 telomere length GO:0000781 chromosome, telomeric region PATO:0000122 length | |||
There was a problem hiding this comment.
Suggested change
| OBA:2050100 telomere length GO:0000781 chromosome, telomeric region PATO:0000122 length |
There is already a term OBA:0003784 that has the same logical definition, so please drop OBA:2050100 from the table.
- removed 2 created OBA terms (OBA:2050100 telomere length & OBA:2050105 cranial vault morphology trait) - already existing as (OBA:0003784 & OBA:VT0000076)
- removed mappings from GitHub oba-efo.sssom.tsv (will only add to Google sheets)
rays22
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.