-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#710): Add org.eolang
and org.eolang.jeo
packages
#713
feat(#710): Add org.eolang
and org.eolang.jeo
packages
#713
Conversation
…ributes. All tests fail!
Blocked by objectionary/eo#3373 (comment) |
@maxonfjvipon This PR blocks other issues in this repository. Are the packages |
@volodya-lombrozo at least for now it's ok |
@rultor merge |
@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here |
@volodya-lombrozo Done! FYI, the full log is here (took me 35min) |
@volodya-lombrozo Thanks for the contribution! You've earned +4 points for this: +4 as a basis; -8 for too many hits-of-code (1529 >= 200); -16 for way too many hits-of-code (1529 >= 800); -16 for the lack of code review; -4 for very few (5) comments; +44 to give you at least something. Please, keep them coming. Your running balance is +89. |
@volodya-lombrozo Great work on your contribution! 🌟 You've earned +4 points, with adjustments for code volume and review. While there's room for improvement in code size and comments, we value your effort. Your running balance is now +89. Keep the contributions coming and remember, quality matters! |
@volodya-lombrozo Great work on your contribution! 🌟 You've earned +4 points, with adjustments for code volume and review. While there's room for improvement in code size and comments, we appreciate your effort. Your balance is now +89. Keep the contributions coming and check out this article for tips on balancing speed and quality! |
@volodya-lombrozo Thanks for your contribution! You've earned +4 points: +4 base, -8 for exceeding 200 hits-of-code (1529), -16 for surpassing 800 hits-of-code, -16 for no code review, -4 for only 5 comments, +44 adjustment. While the code volume is impressive, remember our policy values quality and review. Consider breaking larger contributions into smaller, reviewable chunks. Your balance is now +89. Keep improving and contributing! |
@volodya-lombrozo Great job on your contribution! 🌟 You've earned +4 points, with adjustments for code size and review. While there's room for improvement in code conciseness and comments, we value your effort. Your balance is now +89. Keep up the good work and remember to focus on quality in your next submission! |
@volodya-lombrozo Great work on your contribution! 🎉 You've earned +4 points, with adjustments for code volume and review. While there's room for improvement in code size and comments, we value your effort. Your balance is now +89. Keep the contributions coming and check out our quality tips for future submissions! |
@volodya-lombrozo Thank you for your contribution! We appreciate your effort, but there are some areas for improvement. Your submission of 1529 hits-of-code exceeds our guidelines, resulting in deductions. Additionally, the lack of code review and limited comments (5) have impacted your points. Despite these challenges, you've earned +4 points: +4 base, -24 for excess code, -16 for no review, -4 for few comments, +44 adjustment. Please focus on quality over quantity in future contributions. Your current balance is +89. Keep up the effort, and let's work on improving the review process! |
@volodya-lombrozo Hey there! 👋 Thanks for your contribution! Your effort is appreciated, but it seems we've got some room for improvement. You've earned +4 points, but there were a few hiccups: -8 for exceeding 200 hits-of-code (1529!), -16 for going over 800, -16 for missing code review, and -4 for only 5 comments. We had to add +44 to keep you at the minimum 4 points. Remember, quality over quantity is key! Aim for fewer hits-of-code and make sure to get those code reviews. Keep the contributions coming, and let's work on boosting that +89 balance! 💪 |
@volodya-lombrozo Great work on your contribution! 🌟 You've earned +4 points, with adjustments for code volume and review. While there's room for improvement in code size and comments, we value your effort. Your balance is now +89. Keep the contributions coming and check out our quality guidelines for future submissions! |
@volodya-lombrozo Great work on your contribution! 🌟 You've earned +4 points, despite some areas for improvement. While there were deductions for code volume and review, we appreciate your effort. Your running balance is now +89. For future submissions, consider balancing speed and quality, and don't forget to include more comments. Keep the contributions coming! |
@volodya-lombrozo Great contribution! Here's your reward breakdown: +4 base points, -8 for 1529 hits-of-code (≥200), -16 for exceeding 800 hits-of-code, -16 for no code review, -4 for only 5 comments. We've added +44 to ensure a minimum reward. Your total: +4 points. Remember, smaller, quality contributions with thorough reviews are ideal. Keep them coming! Your balance is now +89. |
@volodya-lombrozo Thanks for the contribution! You've earned +4 points for this: +4 as a basis; -8 for too many hits-of-code (1529 >= 200); -16 for way too many hits-of-code (1529 >= 800); -16 for the lack of code review; -4 for very few (5) comments; +44 to give you at least something. Please, keep them coming. Your running balance is +89. |
1 similar comment
@volodya-lombrozo Thanks for the contribution! You've earned +4 points for this: +4 as a basis; -8 for too many hits-of-code (1529 >= 200); -16 for way too many hits-of-code (1529 >= 800); -16 for the lack of code review; -4 for very few (5) comments; +44 to give you at least something. Please, keep them coming. Your running balance is +89. |
In this PR I added support of FQN for all the generated objects. This involves adding of
org.eolang
andorg.eolang.jeo
packages to all the generated objects.Closes: #710.
History:
base
Attribute #710): add EoFqn and JeoFqn classesbase
Attribute #710): try to apply EoFqn and JeoFqn to all base attributes. All tests fail!base
Attribute #710): fix most of the integration testsbase
Attribute #710): fix all the integration testsbase
Attribute #710): fix all the code offencesbase
Attribute #710): add one more puzzlePR-Codex overview
The focus of this PR is to update XML element base attributes to use fully qualified names in the EO language representation classes.
Detailed summary
JeoFqn
andEoFqn
instances