Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#3251): socket.connect syscall #3386

Merged
merged 5 commits into from
Sep 25, 2024

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented Sep 24, 2024

Ref: #3251


PR-Codex overview

This PR focuses on enhancing the EOposix functionality by adding new syscalls for network operations, specifically for handling sockets, and updating related tests. It introduces several new classes and methods to facilitate TCP connections and error handling.

Detailed summary

  • Added new syscalls: ConnectSyscall, InetAddrSyscall, StrerrorSyscall, and ErrnoSyscall.
  • Introduced SockaddrIn structure for socket address representation.
  • Updated CStdLib interface with TCP-related constants and socket methods.
  • Enhanced EOsocketTest to include tests for POSIX socket connections.
  • Modified codacy.yml to exclude new files from checks.
  • Updated Eolang scripts to support new socket functionalities.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@maxonfjvipon
Copy link
Member Author

@yegor256 please check

Copy link
Member

@yegor256 yegor256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Sep 25, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 6427056 into objectionary:master Sep 25, 2024
21 checks passed
@rultor
Copy link
Contributor

rultor commented Sep 25, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 31min)

@0crat
Copy link

0crat commented Sep 25, 2024

@yegor256 Hello! Thank you for your code review. Based on our team's policy, you've earned +16 points for this contribution: +4 as the base reward, +16 for the 778 hits-of-code you reviewed (capped at 16 points), and -4 for the low number of comments (4). While we appreciate your effort, we encourage more detailed feedback in future reviews to maximize your rewards. Your updated balance is now -31. Keep up the good work and remember that more comprehensive reviews benefit both you and the team! 💻👍

@0crat
Copy link

0crat commented Sep 25, 2024

@maxonfjvipon Thank you for your contribution! Your effort is appreciated, but there are some areas for improvement. You've earned +4 points: +4 base, -8 for excessive hits-of-code (778 ≥ 200), -4 for only 3 comments, and +12 adjustment to meet the minimum. Remember to focus on quality and encourage more detailed code reviews. Your updated balance is +36. Keep up the good work and aim for more concise contributions with thorough reviews next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants