-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#3251): socket.connect
syscall
#3386
feat(#3251): socket.connect
syscall
#3386
Conversation
@yegor256 please check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@rultor merge |
@yegor256 Hello! Thank you for your code review. Based on our team's policy, you've earned +16 points for this contribution: +4 as the base reward, +16 for the 778 hits-of-code you reviewed (capped at 16 points), and -4 for the low number of comments (4). While we appreciate your effort, we encourage more detailed feedback in future reviews to maximize your rewards. Your updated balance is now -31. Keep up the good work and remember that more comprehensive reviews benefit both you and the team! 💻👍 |
@maxonfjvipon Thank you for your contribution! Your effort is appreciated, but there are some areas for improvement. You've earned +4 points: +4 base, -8 for excessive hits-of-code (778 ≥ 200), -4 for only 3 comments, and +12 adjustment to meet the minimum. Remember to focus on quality and encourage more detailed code reviews. Your updated balance is +36. Keep up the good work and aim for more concise contributions with thorough reviews next time! |
Ref: #3251
PR-Codex overview
This PR focuses on enhancing the
EOposix
functionality by adding new syscalls for network operations, specifically for handling sockets, and updating related tests. It introduces several new classes and methods to facilitate TCP connections and error handling.Detailed summary
ConnectSyscall
,InetAddrSyscall
,StrerrorSyscall
, andErrnoSyscall
.SockaddrIn
structure for socket address representation.CStdLib
interface with TCP-related constants and socket methods.EOsocketTest
to include tests for POSIX socket connections.codacy.yml
to exclude new files from checks.