-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#3251): introduced i64
object
#3337
feat(#3251): introduced i64
object
#3337
Conversation
@yegor256 I need your advice: what should |
@yegor256 WDYT? |
@yegor256 please check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxonfjvipon LGTM, thanks!
@rultor merge |
@maxonfjvipon Great contribution! Your efforts have earned you +4 points: +4 base, -8 for exceeding 200 hits-of-code (1135), -16 for surpassing 800 hits-of-code, -4 for only 5 review comments, and +28 adjustment to ensure fair compensation. While the code volume was high, remember that quality often trumps quantity. Your current balance stands at +72. Keep up the good work, and consider more compact, well-reviewed contributions in the future! |
@yegor256 Great job on the review! 🎉 Your efforts have earned you +5 points: +4 base points, +16 (capped from +11.35) for reviewing 1135 hits-of-code, -10 for having only 5 comments, and -5 for self-review. Remember, more comments can boost your score next time! Your current balance stands at +114. Keep up the excellent work! |
Ref: #3251
What's done:
i64
is introducednumber.is-nan
,number.is-finite
,number.is-integer
objects are addednan
,positive-infinity
andnegative-infinity
are changedData.ToPhi
can returnnan
,positive-infinity
ornegative-infinity
objectshash-code-of
andtext
objects are fixedPR-Codex overview
The focus of this PR is to add new tests, improve error handling, and optimize type conversions in EO programming language modules.
Detailed summary