Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#3251): introduced i64 object #3337

Merged
merged 21 commits into from
Sep 4, 2024

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented Aug 15, 2024

Ref: #3251

What's done:

  1. the object i64 is introduced
  2. number.is-nan, number.is-finite, number.is-integer objects are added
  3. implementations of nan, positive-infinity and negative-infinity are changed
  4. Data.ToPhi can return nan, positive-infinity or negative-infinity objects
  5. implementations of hash-code-of and text objects are fixed
  6. some tests are fixed

PR-Codex overview

The focus of this PR is to add new tests, improve error handling, and optimize type conversions in EO programming language modules.

Detailed summary

  • Added new tests for various functionalities
  • Improved error handling for type conversions
  • Optimized type conversions in EO modules

The following files were skipped due to too many changes: eo-runtime/src/main/java/org/eolang/Data.java, eo-runtime/src/main/eo/org/eolang/positive-infinity.eo, eo-runtime/src/main/java/EOorg/EOeolang/EOi64$EOas_number.java, eo-runtime/src/main/java/EOorg/EOeolang/EOnumber$EOas_i64.java, eo-runtime/src/main/java/EOorg/EOeolang/EOi64$EOgt.java, eo-runtime/src/main/java/EOorg/EOeolang/EOi64$EOdiv.java, eo-runtime/src/main/java/EOorg/EOeolang/EOi64$EOtimes.java, eo-runtime/src/main/java/EOorg/EOeolang/EOi64$EOplus.java, eo-runtime/src/main/eo/org/eolang/i64.eo, eo-runtime/src/main/eo/org/eolang/number.eo, eo-runtime/src/test/eo/org/eolang/i64-tests.eo

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@maxonfjvipon
Copy link
Member Author

maxonfjvipon commented Aug 16, 2024

@yegor256 I need your advice: what should i64 object decorate - bytes or number? If it decorates number then all bytes operations would skip i64.as-bytes representation which is different from number.as-bytes representation. My opinion that decorating bytes is better, don't really know why but it seems so... Now it decorates bytes

@maxonfjvipon
Copy link
Member Author

@yegor256 WDYT?

@maxonfjvipon
Copy link
Member Author

@yegor256 please check

Copy link
Member

@yegor256 yegor256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxonfjvipon LGTM, thanks!

@yegor256
Copy link
Member

yegor256 commented Sep 4, 2024

@rultor merge

@rultor
Copy link
Contributor

rultor commented Sep 4, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit fc2ca07 into objectionary:master Sep 4, 2024
21 checks passed
@rultor
Copy link
Contributor

rultor commented Sep 4, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 42min)

@0crat
Copy link

0crat commented Sep 4, 2024

@maxonfjvipon Great contribution! Your efforts have earned you +4 points: +4 base, -8 for exceeding 200 hits-of-code (1135), -16 for surpassing 800 hits-of-code, -4 for only 5 review comments, and +28 adjustment to ensure fair compensation. While the code volume was high, remember that quality often trumps quantity. Your current balance stands at +72. Keep up the good work, and consider more compact, well-reviewed contributions in the future!

@0crat
Copy link

0crat commented Sep 4, 2024

@yegor256 Great job on the review! 🎉 Your efforts have earned you +5 points: +4 base points, +16 (capped from +11.35) for reviewing 1135 hits-of-code, -10 for having only 5 comments, and -5 for self-review. Remember, more comments can boost your score next time! Your current balance stands at +114. Keep up the excellent work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants