Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1249: It should align inner classes in tests #3243

Merged
merged 6 commits into from
Jul 15, 2024

Conversation

levBagryansky
Copy link
Member

@levBagryansky levBagryansky commented Jun 27, 2024

Closes #1249

I added 2 transformations:

  1. first copies nested-in-nested classes inside the main class;
  2. second remove all nested-in-nested classes;

I also changed the naming convention of nested classes


PR-Codex overview

This PR optimizes the Maven plugin by aligning test classes, removing high-level inner classes, and updating XSL files.

Detailed summary

  • Added XSL files for aligning and removing classes
  • Updated XSL files for tests
  • Updated test YAML file
  • Updated Java test file

The following files were skipped due to too many changes: eo-runtime/src/test/eo/org/eolang/runtime-tests.eo

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@levBagryansky
Copy link
Member Author

@maxonfjvipon please review

@levBagryansky
Copy link
Member Author

@yegor256 please check

4 similar comments
@levBagryansky
Copy link
Member Author

@yegor256 please check

@levBagryansky
Copy link
Member Author

@yegor256 please check

@levBagryansky
Copy link
Member Author

@yegor256 please check

@levBagryansky
Copy link
Member Author

@yegor256 please check

@levBagryansky
Copy link
Member Author

@yegor256 please take a look

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Jul 15, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Contributor

rultor commented Jul 15, 2024

@rultor merge

@levBagryansky @yegor256 Oops, I failed. You can see the full log here (spent 44min)

[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 s -- in EOorg.EOeolang.EOsupports_escape_sequencesTest
[INFO] Running EOorg.EOeolang.EOnan_not_gt_numberTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 s -- in EOorg.EOeolang.EOnan_not_gt_numberTest
[INFO] Running org.eolang.PhMethodTest
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.007 s -- in org.eolang.PhMethodTest
[INFO] Running EOorg.EOeolang.EOfloat_plus_nan_is_nanTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 s -- in EOorg.EOeolang.EOfloat_plus_nan_is_nanTest
[INFO] Running EOorg.EOeolang.EOpositive_infinity_div_neg_int_zeroTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.005 s -- in EOorg.EOeolang.EOpositive_infinity_div_neg_int_zeroTest
[INFO] Running EOorg.EOeolang.EOor_with_two_plusTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.004 s -- in EOorg.EOeolang.EOor_with_two_plusTest
[INFO] Running EOorg.EOeolang.EOdiv_for_dividend_greater_than_zeroTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 s -- in EOorg.EOeolang.EOdiv_for_dividend_greater_than_zeroTest
[INFO] Running EOorg.EOeolang.EOstringEOsliceTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.139 s -- in EOorg.EOeolang.EOstringEOsliceTest
[INFO] Running EOorg.EOeolang.EOcompares_two_different_stringsTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 s -- in EOorg.EOeolang.EOcompares_two_different_stringsTest
[INFO] Running EOorg.EOeolang.EOstructs.EOfinds_index_of_stringTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.097 s -- in EOorg.EOeolang.EOstructs.EOfinds_index_of_stringTest
[INFO] Running EOorg.EOeolang.EOor_neg_bytes_as_int_without_leading__zeroesTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.087 s -- in EOorg.EOeolang.EOor_neg_bytes_as_int_without_leading__zeroesTest
[INFO] Running EOorg.EOeolang.EOmemory_is_strictly_sized_stringTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.311 s -- in EOorg.EOeolang.EOmemory_is_strictly_sized_stringTest
[INFO] Running EOorg.EOeolang.EOpositive_infinity_div_positive_infinityTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.004 s -- in EOorg.EOeolang.EOpositive_infinity_div_positive_infinityTest
[INFO] Running EOorg.EOeolang.EOpositive_infinity_gt_negative_infinityTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.457 s -- in EOorg.EOeolang.EOpositive_infinity_gt_negative_infinityTest
[INFO] Running EOorg.EOeolang.EOtakes_part_of_bytesTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 s -- in EOorg.EOeolang.EOtakes_part_of_bytesTest
[INFO] Running EOorg.EOeolang.EOfloat_less_trueTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.079 s -- in EOorg.EOeolang.EOfloat_less_trueTest
[INFO] Running EOorg.EOeolang.EOslice_in_the_middleTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 s -- in EOorg.EOeolang.EOslice_in_the_middleTest
[INFO] Running EOorg.EOeolang.EOslice_foreign_literalsTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 s -- in EOorg.EOeolang.EOslice_foreign_literalsTest
[INFO] Running EOorg.EOeolang.EOneg_zero_gte_zeroTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.086 s -- in EOorg.EOeolang.EOneg_zero_gte_zeroTest
[INFO] Running EOorg.EOeolang.EOmalloc_is_strictly_sized_bool_error_overflowTest
Error at "EOorg.EOeolang.EOmalloc$EOof$EOallocated$EOwrite#λ" attribute; caused by Can't write 8 bytes with offset 0 to the block with identifier 1987744, because only 1 were allocated[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.151 s -- in EOorg.EOeolang.EOmalloc_is_strictly_sized_bool_error_overflowTest
[INFO] Running EOorg.EOeolang.EOstructs.EOfinds_last_index_ofTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.139 s -- in EOorg.EOeolang.EOstructs.EOfinds_last_index_ofTest
[INFO] Running EOorg.EOeolang.EOint_leq_falseTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 s -- in EOorg.EOeolang.EOint_leq_falseTest
[INFO] Running EOorg.EOeolang.EOand_with_zeroTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 s -- in EOorg.EOeolang.EOand_with_zeroTest
[INFO] Running EOorg.EOeolang.EOpositive_infinity_as_bytes_is_validTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.004 s -- in EOorg.EOeolang.EOpositive_infinity_as_bytes_is_validTest
[INFO] Running EOorg.EOeolang.EOint_greater_falseTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 s -- in EOorg.EOeolang.EOint_greater_falseTest
[INFO] Running EOorg.EOeolang.EOint_zero_eq_to_zeroTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 s -- in EOorg.EOeolang.EOint_zero_eq_to_zeroTest
[INFO] Running EOorg.EOeolang.EOio.EOstdinTest
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.253 s -- in EOorg.EOeolang.EOio.EOstdinTest
[INFO] Running EOorg.EOeolang.EOcalculates_fibonacci_number_with_recursionTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.226 s -- in EOorg.EOeolang.EOcalculates_fibonacci_number_with_recursionTest
[INFO] Running EOorg.EOeolang.EOneg_zero_not_greater_that_zeroTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 s -- in EOorg.EOeolang.EOneg_zero_not_greater_that_zeroTest
/home/r/script.sh: line 9:  1675 Killed                  mvn clean install -Pqulice --errors -Dstyle.color=never
container d8953a2c694bb1fba15c4a9d690bb7e7d0ae2d62e07700c3127faf80ddfe682d is dead
Mon Jul 15 10:08:44 UTC 2024

@yegor256 yegor256 merged commit f26ee33 into objectionary:master Jul 15, 2024
22 checks passed
@levBagryansky levBagryansky deleted the 1249_add-test branch July 15, 2024 12:27
@0crat
Copy link

0crat commented Jul 15, 2024

@levBagryansky Thanks for the contribution! You've earned +5 points for this (+20 as a basis, -7 for too many hits-of-code (240), -19 for 19 comments, +11 it is too few). Please, keep them coming. Your running balance is +47.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate concise Java code for tests
5 participants