Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sonar reliability issues #3241

Merged
merged 10 commits into from
Jul 29, 2024

Conversation

c71n93
Copy link
Member

@c71n93 c71n93 commented Jun 26, 2024

Related to #2251

Check current reliability issues in recent sonar report

They should be fixed in this pull request (except for issues with removing static "ThreadLocal" variables). Check sonar report for test branch in my fork (exact copy of this branch with changes for running sonar in my local repo).


PR-Codex overview

This PR focuses on removing memory leaks by calling ThreadLocal#remove() on specific variables.

Detailed summary

  • Updated PhDefault, PhTraced, Dataized classes to include @todo for memory leak prevention.
  • Modified OnDefault to handle empty label().
  • Updated DcsFake to use rand.nextInt(Integer.MAX_VALUE) instead of Math.abs(rand.nextInt()).
  • Refactored test in PullMojoTest to use FakeMaven for better readability.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@c71n93
Copy link
Member Author

c71n93 commented Jun 26, 2024

@yegor256 could you check this one, please?

1 similar comment
@c71n93
Copy link
Member Author

c71n93 commented Jul 8, 2024

@yegor256 could you check this one, please?

@c71n93
Copy link
Member Author

c71n93 commented Jul 22, 2024

@yegor256 could you please check this one?

@yegor256 yegor256 merged commit 5b1a1cf into objectionary:master Jul 29, 2024
22 checks passed
@0crat
Copy link

0crat commented Jul 29, 2024

@c71n93 Thanks for the contribution! You've earned +11 points for this: +30 as a basis; +6 for the 64 hits-of-code that you wrote; -15 for the lack of code review; -10 for too few (3) comments. Please, keep them coming. Your running balance is +72.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants