-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3140: Save error message #3185
base: master
Are you sure you want to change the base?
Conversation
@maxonfjvipon WDYT |
@maxonfjvipon please check |
eo-maven-plugin/src/test/java/org/eolang/maven/WeHaveCargo.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@levBagryansky LGTM!
@levBagryansky did you try to use |
@yegor256 Yes, it still did not print it. |
@levBagryansky we should find out, why it doesn't print. Most probably, something is wrong with the configuration of logging levels in |
@yegor256 |
@levBagryansky why it's important to put entire stdout into an exception (pretty unusual practice) instead of just sending it to the console/log? What do you mean by "we cannot get it"? If you can see the stacktrace (printed to stderr), you should see the log printed to stdout, I believe. |
@yegor256 because usually we would not like to see logs for all cargo projects. There are several inserts in eo program so logs from them would be mixed. |
@yegor256 We would like to get |
Closes #3140
PR-Codex overview
The focus of this PR is to enhance the Rust build process in the Maven plugin by introducing new features and improvements.
Detailed summary
WeHaveCargo
as an execution condition for Rust buildsBuildFailureException
RustNode
class