Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#3147): remove sigma #3168

Merged
merged 12 commits into from
May 8, 2024

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented May 6, 2024

Closes: #3147


PR-Codex overview

This PR removes unused classes, constants, and methods. It refactors constructors and simplifies code structure.

Detailed summary

  • Deleted unused classes and resources
  • Removed constant SIGMA
  • Refactored constructors in multiple classes
  • Simplified method implementations

The following files were skipped due to too many changes: eo-runtime/src/main/java/EOorg/EOeolang/EOfloat$EOplus.java, eo-runtime/src/main/eo/org/eolang/malloc.eo, eo-runtime/src/main/java/EOorg/EOeolang/EObytes$EOright.java, eo-runtime/src/main/java/EOorg/EOeolang/EOfloat$EOtimes.java, eo-runtime/src/main/java/EOorg/EOeolang/EObytes$EOconcat.java, eo-runtime/src/main/java/EOorg/EOeolang/EOstring$EOlength.java, eo-runtime/src/main/eo/org/eolang/nan.eo, eo-runtime/src/main/java/EOorg/EOeolang/EOstring$EOas_bytes.java, eo-maven-plugin/src/test/resources/org/eolang/maven/phi/yaml/fibonaci.yaml, eo-maven-plugin/src/main/resources/org/eolang/maven/pre/attrs.xsl, eo-runtime/src/main/java/org/eolang/Main.java, /eo-runtime/src/main/java/EOorg/EOeolang/EOmalloc$EOof$EO\317\206.java", eo-runtime/src/main/eo/org/eolang/go.eo, eo-runtime/src/test/java/org/eolang/PhDataTest.java, eo-runtime/src/main/java/EOorg/EOeolang/EObytes$EOslice.java, eo-runtime/src/main/java/EOorg/EOeolang/EObytes$EOsize.java, eo-runtime/src/main/java/EOorg/EOeolang/EOstring$EOslice.java, /eo-runtime/src/main/java/EOorg/EOeolang/EOcage$EOencaged$EO\317\206.java", eo-runtime/src/test/java/EOorg/EOeolang/EOfailed.java, eo-runtime/src/test/eo/org/eolang/switch-tests.eo, eo-runtime/src/main/java/EOorg/EOeolang/EOio/EOstdout.java, eo-runtime/src/test/eo/org/eolang/goto-tests.eo, eo-runtime/src/test/eo/org/eolang/seq-tests.eo, eo-maven-plugin/src/test/resources/org/eolang/maven/packs/pre/synthetic-attributes-with-to-java.yaml, eo-parser/src/test/resources/org/eolang/parser/packs/add-locators.yaml, eo-maven-plugin/src/test/resources/org/eolang/maven/packs/pre/converts-to-java-with-arrays-and-scopes.yaml, /eo-runtime/src/main/java/EOorg/EOeolang/EOcage$EO\317\206.java", eo-runtime/src/main/java/org/eolang/AtRho.java, eo-runtime/src/test/java/EOorg/EOeolang/EOintTest.java, eo-maven-plugin/src/test/resources/org/eolang/maven/packs/pre/embedded-class.yaml, eo-runtime/src/test/java/org/eolang/ExInterruptedTest.java, eo-runtime/src/test/eo/org/eolang/string-tests.eo, eo-runtime/src/main/java/org/eolang/AtSetRho.java, eo-runtime/src/main/eo/org/eolang/negative-infinity.eo, eo-runtime/src/main/eo/org/eolang/positive-infinity.eo, eo-runtime/src/test/java/EOorg/EOeolang/EOseqTest.java, eo-runtime/src/main/java/org/eolang/PhWrite.java, eo-runtime/src/test/eo/org/eolang/tuple-tests.eo, eo-runtime/src/test/eo/org/eolang/malloc-tests.eo, eo-runtime/src/test/eo/org/eolang/try-tests.eo, eo-runtime/src/main/java/EOorg/EOeolang/EOio/Input.java, eo-maven-plugin/src/test/resources/org/eolang/maven/unphi/specials.yaml, eo-runtime/src/test/java/org/eolang/PhMethodTest.java, eo-maven-plugin/src/test/resources/org/eolang/maven/packs/pre/dot-home.yaml, eo-runtime/src/test/eo/org/eolang/cage-tests.eo, eo-runtime/src/test/eo/org/eolang/while-tests.eo, eo-maven-plugin/src/main/resources/org/eolang/maven/phi/to-phi.xsl, eo-runtime/src/test/java/EOorg/EOeolang/EOcageTest.java, eo-runtime/src/test/java/org/eolang/DataizedTest.java, eo-maven-plugin/src/test/resources/org/eolang/maven/unphi/auto-named.yaml, eo-runtime/src/test/java/EOorg/EOeolang/EOtupleEOatTest.java, eo-parser/src/test/resources/org/eolang/parser/packs/syntax/bool-tests-straight.yaml, eo-runtime/src/test/java/EOorg/EOeolang/EOio/EOstdoutTest.java, eo-runtime/src/main/java/org/eolang/PhDefault.java, eo-runtime/src/test/java/EOorg/EOeolang/EOtryTest.java, eo-runtime/src/test/java/org/eolang/PhWithTest.java, eo-runtime/src/test/java/org/eolang/UniverseDefaultTest.java, eo-runtime/src/test/eo/org/eolang/rust-tests.eo, eo-runtime/src/test/eo/org/eolang/runtime-tests.eo, eo-maven-plugin/src/test/resources/org/eolang/maven/unphi/bool-tests.yaml, eo-runtime/src/test/java/EOorg/EOeolang/EOio/EOstdinTest.java, eo-runtime/src/test/java/org/eolang/PhDefaultTest.java, eo-maven-plugin/src/main/resources/org/eolang/maven/pre/to-java.xsl

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@maxonfjvipon
Copy link
Member Author

@yegor256 please check

@yegor256
Copy link
Member

yegor256 commented May 8, 2024

@rultor merge

@rultor
Copy link
Contributor

rultor commented May 8, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit a71be6d into objectionary:master May 8, 2024
21 checks passed
@rultor
Copy link
Contributor

rultor commented May 8, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 22min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

let's get rid of sigma
3 participants