-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update actions/checkout digest to 8459bc0 #3138
Conversation
@@ -15,5 +15,5 @@ jobs: | |||
markdown-lint: | |||
runs-on: ubuntu-22.04 | |||
steps: | |||
- uses: actions/checkout@43045ae669be728bd34ed56fcd1a230c0dc4d8e2 | |||
- uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b | |||
- uses: articulate/actions-markdownlint@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diff you've provided indicates that the version of the GitHub Actions actions/checkout
action being used in a GitHub Actions workflow file is changed. While it has moved from one specific commit hash (43045ae669be728bd34ed56fcd1a230c0dc4d8e2
) to another (0ad4b8fadaa221de15dcec353f45205ec38ea70b
), it is hard to determine whether this will create confusion or pose irregularities as this heavily depends on the changes introduced between these two commits.
Though not common, referencing GitHub actions by commit hash is perfectly valid and can be done when an explicit control over the used version is needed. This does take away from readability, however, since commit hashes are less understandable than semantic version numbers. It would be more typical and clear to see code specifying the use of an action like so:
- uses: actions/checkout@v2
In this case, you'd know the action is using version 2 of actions/checkout. But without insight into the specific changes made in the "actions/checkout" action between the two indicated commit hashes, there are no apparent issues with what you posted.
ea6e0d0
to
2b1371e
Compare
@@ -15,5 +15,5 @@ jobs: | |||
markdown-lint: | |||
runs-on: ubuntu-22.04 | |||
steps: | |||
- uses: actions/checkout@43045ae669be728bd34ed56fcd1a230c0dc4d8e2 | |||
- uses: actions/checkout@9c1e94e0ad997d618b6113a2171b055037589028 | |||
- uses: articulate/actions-markdownlint@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code diff you have provided is for a GitHub Actions workflow. No confusions or irregularities are apparent in the diff. It demonstrates a change in the version of the actions/checkout
action used in your workflow, from the commit SHA 43045ae669be728bd34ed56fcd1a230c0dc4d8e2
to 9c1e94e0ad997d618b6113a2171b055037589028
.
Assuming that the new checkout version (referenced by the new commit SHA 9c1e94e0ad997d618b6113a2171b055037589028
) exists and is compatible with the rest of your workflow, this is a standard update and should not cause any issues.
2b1371e
to
137e8fe
Compare
@@ -15,5 +15,5 @@ jobs: | |||
markdown-lint: | |||
runs-on: ubuntu-22.04 | |||
steps: | |||
- uses: actions/checkout@43045ae669be728bd34ed56fcd1a230c0dc4d8e2 | |||
- uses: actions/checkout@8459bc0c7e3759cdf591f513d9f141a95fef0a8f | |||
- uses: articulate/actions-markdownlint@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code diff you provided refers to a change in the GitHub Actions workflow file. Specifically, it indicates a single-line change in the markdown-lint
job.
This line represents a step in your workflow that checks out your repository using the actions/checkout
action. Previously, the actions/checkout
action was pointed to a specific commit (43045ae669be728bd34ed56fcd1a230c0dc4d8e2
), and now it points to a different commit (8459bc0c7e3759cdf591f513d9f141a95fef0a8f
).
There are no confusions or irregularities visible in this diff based on the information provided. However, this assumes that the new commit 8459bc0c7e3759cdf591f513d9f141a95fef0a8f
in actions/checkout
exists and functions as expected. If it does not exist or introduces unexpected behavior, there could be issues when executing this GitHub Action.
@rultor please, try to merge, since 18 checks have passed |
This PR contains the following updates:
43045ae
->8459bc0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.
PR-Codex overview
This PR updates the GitHub Actions workflow for markdown linting. It changes the version of the
actions/checkout
action.Detailed summary
actions/checkout
action to version8459bc0c7e3759cdf591f513d9f141a95fef0a8f