Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#2460): fix assembleWithVersions test #2461

Merged
merged 1 commit into from
Aug 31, 2023
Merged

fix(#2460): fix assembleWithVersions test #2461

merged 1 commit into from
Aug 31, 2023

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented Aug 30, 2023 •
edited by pr-codex bot
Loading

Closes: #2460

PR-Codex overview

This PR focuses on removing the eo-runtime-0.30.0.jar dependency.

Detailed summary

  • Removed eo-runtime-0.30.0.jar from the test case AssembleMojoTest.java.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@maxonfjvipon
Copy link
Member Author

@yegor256 please have a look

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Aug 31, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 9476573 into objectionary:master Aug 31, 2023
10 checks passed
@rultor
Copy link
Contributor

rultor commented Aug 31, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 12min)

@maxonfjvipon maxonfjvipon deleted the fix/#2460/assemble-with-versions branch September 18, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AssembleMojoTest.assemblesTogetherWithVersions is broken?
3 participants
@maxonfjvipon @yegor256 @rultor