Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#2435): tests that uses memory #2450

Merged

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented Aug 29, 2023

Closes: #2435


PR-Codex overview

This PR focuses on fixing memory-related issues in the code.

Detailed summary

  • Added .as-int to ^.malloc.next in heap.eo
  • Added a TODO comment in tuple-tests.eo
  • Added a TODO comment in EOmemoryTest.java
  • Changed assert-that > res to assert-that > @ in heap-tests.eo
  • Removed nop > @ in mallocs-do-not-overlap test in heap-tests.eo
  • Changed assert-that > res to assert-that > @ in malloc-return-error test in heap-tests.eo
  • Removed nop > @ in write-and-read-without-error test in heap-tests.eo
  • Removed assert-that > res in iterates-over-simple-counter test in bool-tests.eo
  • Changed ^.^.^ > x to x.write in iterates-over-simple-counter test in bool-tests.eo
  • Removed nop > @ in iterates-over-simple-counter test in bool-tests.eo
  • Removed assert-that > res in complex-bool-expression-in-while test in bool-tests.eo
  • Changed m.write (m.as-int.minus 1) to m.write and m.as-int.minus 1 in complex-bool-expression-in-while test in bool-tests.eo
  • Removed nop > @ in complex-bool-expression-in-while test in bool-tests.eo
  • Removed @Disabled annotation in loopsOverAbstractObjects test in EOboolEOwhileTest.java
  • Changed new PhCopy(new PhMethod(toggle, "while")) to toggle.attr("as-bool").get().attr("while").get().copy() in loopsOverAbstractObjects test in EOboolEOwhileTest.java
  • Removed @Disabled annotation in dataizesComplexBooleanToggle test in EOboolEOwhileTest.java
  • Changed final Phi parent = new Parent(Phi.Φ); to final Phi toggle = new PhMethod(new Parent(Phi.Φ), "toggle"); in dataizesComplexBooleanToggle test in EOboolEOwhileTest.java

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@maxonfjvipon
Copy link
Member Author

@Graur please have a look

@maxonfjvipon
Copy link
Member Author

@Graur please have a look one more time

Copy link
Contributor

@Graur Graur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxonfjvipon Good one!
@yegor256 Please have a look

@maxonfjvipon
Copy link
Member Author

@yegor256 please have a look

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Aug 29, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit e8377e9 into objectionary:master Aug 29, 2023
10 checks passed
@rultor
Copy link
Contributor

rultor commented Aug 29, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 13min)

@maxonfjvipon maxonfjvipon deleted the fix/#2435/tests-that-uses-memory branch September 18, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EOmemoryTest.java:44-51: Enable tests that uses memory...
5 participants