-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataize returns u8 array #2444
Dataize returns u8 array #2444
Conversation
@Graur could you please take a look |
@levBagryansky Were is the related issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@levBagryansky Thanks!
@yegor256 Please take a look
@yegor256 please take a look |
@rultor merge |
@levBagryansky @yegor256 Oops, I failed. You can see the full log here (spent 2min)
|
@yegor256 please check, there were conficts with other branches related to rust inserts |
@rultor merge |
Closes: #2445
eo_env.dataize
should returnVec<u8>
in order to avoid unsafe operations in the insert.PR-Codex overview
This PR focuses on changing the
dataize
function ineo_env.rs
to return aVec<u8>
instead ofVec<i8>
. It also updates the usage ofdataize
inrust-tests.eo
to handle the new return type.Detailed summary
dataize
function ineo_env.rs
to returnVec<u8>
instead ofVec<i8>
dataize
inrust-tests.eo
to handle new return type