Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataize returns u8 array #2444

Merged
merged 3 commits into from
Aug 29, 2023

Conversation

levBagryansky
Copy link
Member

@levBagryansky levBagryansky commented Aug 25, 2023

Closes: #2445
eo_env.dataize should return Vec<u8> in order to avoid unsafe operations in the insert.


PR-Codex overview

This PR focuses on changing the dataize function in eo_env.rs to return a Vec<u8> instead of Vec<i8>. It also updates the usage of dataize in rust-tests.eo to handle the new return type.

Detailed summary

  • Changed dataize function in eo_env.rs to return Vec<u8> instead of Vec<i8>
  • Updated usage of dataize in rust-tests.eo to handle new return type

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@levBagryansky
Copy link
Member Author

@Graur could you please take a look

@Graur
Copy link
Contributor

Graur commented Aug 25, 2023

@levBagryansky Were is the related issue?

@levBagryansky
Copy link
Member Author

@Graur it here: #2445

Copy link
Contributor

@Graur Graur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@levBagryansky Thanks!
@yegor256 Please take a look

@levBagryansky
Copy link
Member Author

@yegor256 please take a look

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Aug 28, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Contributor

rultor commented Aug 28, 2023

@rultor merge

@levBagryansky @yegor256 Oops, I failed. You can see the full log here (spent 2min)

 * [new branch]          2003_build_prerequisities -> fork/2003_build_prerequisities
 * [new branch]          2011_Rusr_name_loc2code_csv -> fork/2011_Rusr_name_loc2code_csv
 * [new branch]          2011_Rust_name_loc2code  -> fork/2011_Rust_name_loc2code
 * [new branch]          2032_EOrust              -> fork/2032_EOrust
 * [new branch]          2091_slow                -> fork/2091_slow
 * [new branch]          2157_equals              -> fork/2157_equals
 * [new branch]          2195_cargos              -> fork/2195_cargos
 * [new branch]          2197_Cache-rust          -> fork/2197_Cache-rust
 * [new branch]          2283_enum                -> fork/2283_enum
 * [new branch]          2293_put                 -> fork/2293_put
 * [new branch]          2295_find                -> fork/2295_find
 * [new branch]          2314_handle_vertex_returning -> fork/2314_handle_vertex_returning
 * [new branch]          2322_SavableCargo        -> fork/2322_SavableCargo
 * [new branch]          2425_find                -> fork/2425_find
 * [new branch]          2433_primitives-hashcode -> fork/2433_primitives-hashcode
 * [new branch]          796_parsing_process_documentation -> fork/796_parsing_process_documentation
 * [new branch]          N1087_remove_array.empty -> fork/N1087_remove_array.empty
 * [new branch]          Universe_creation        -> fork/Universe_creation
 * [new branch]          checking-windows-tests   -> fork/checking-windows-tests
 * [new branch]          dataize-returns-u8-array -> fork/dataize-returns-u8-array
 * [new branch]          empty                    -> fork/empty
 * [new branch]          empty_ch                 -> fork/empty_ch
 * [new branch]          empty_changes            -> fork/empty_changes
 * [new branch]          gh-pages                 -> fork/gh-pages
 * [new branch]          master                   -> fork/master
 * [new branch]          measures                 -> fork/measures
 * [new branch]          measures_2               -> fork/measures_2
 * [new branch]          my-atom                  -> fork/my-atom
 * [new branch]          regex_match              -> fork/regex_match
 * [new branch]          test_branch              -> fork/test_branch
 * [new branch]          version-up               -> fork/version-up
+ args=
+ '[' default == default ']'
+ args=' --ff'
+ '[' default == no ']'
+ '[' default == only ']'
+ export BRANCH=__rultor
+ BRANCH=__rultor
++ git show-branch __rultor
++ wc -l
+ '[' 0 -gt 0 ']'
+ git status
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean
+ git checkout -B __rultor fork/dataize-returns-u8-array
Switched to a new branch '__rultor'
Branch '__rultor' set up to track remote branch 'dataize-returns-u8-array' from 'fork'.
+ git checkout -B master origin/master
Switched to and reset branch 'master'
Branch 'master' set up to track remote branch 'master' from 'origin'.
Your branch is up to date with 'origin/master'.
+ '[' false == true ']'
+ '[' false == true ']'
+ git merge --ff __rultor
Auto-merging eo-runtime/src/test/eo/org/eolang/rust-tests.eo
CONFLICT (content): Merge conflict in eo-runtime/src/test/eo/org/eolang/rust-tests.eo
Automatic merge failed; fix conflicts and then commit the result.
'cid' file is absent, most probably the Docker container wasn't started correctly

@levBagryansky
Copy link
Member Author

@yegor256 please check, there were conficts with other branches related to rust inserts

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Aug 29, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit a784ea7 into objectionary:master Aug 29, 2023
10 checks passed
@rultor
Copy link
Contributor

rultor commented Aug 29, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 12min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eo_env.dataize should return Vec<u8> in order to avoid unsafe operations in the insert.
4 participants