Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#2438): memory with limitations #2440

Merged

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented Aug 24, 2023

Closes: #2438


PR-Codex overview

Focus of the PR

This PR focuses on adding new test cases and making changes to the memory implementation in order to handle memory allocation and writing more efficiently.

Detailed summary

  • Added test cases for checking that memory does not write more than allocated
  • Added test case for writing less and rewriting the same amount of memory
  • Modified the memory implementation to track the allocated bytes length
  • Updated the memory implementation to throw an error if trying to write more than allocated

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@maxonfjvipon
Copy link
Member Author

@Graur please review this one

Copy link
Contributor

@Graur Graur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxonfjvipon I like it, thanks!
@yegor256 Could you please have a look?

@maxonfjvipon
Copy link
Member Author

@yegor256 please have a look

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Aug 25, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 4a3c0db into objectionary:master Aug 25, 2023
10 checks passed
@rultor
Copy link
Contributor

rultor commented Aug 25, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 13min)

@maxonfjvipon maxonfjvipon deleted the feat/#2438/memory-with-limitations branch September 18, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

memory must have a fixed upper limit of the size of the data it holds
4 participants