-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(#2227): Refactor ForeignTojos Attribute #2233
Merged
rultor
merged 6 commits into
objectionary:master
from
volodya-lombrozo:2227_fullfill_foreign
Jul 12, 2023
Merged
refactor(#2227): Refactor ForeignTojos Attribute #2233
rultor
merged 6 commits into
objectionary:master
from
volodya-lombrozo:2227_fullfill_foreign
Jul 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@maxonfjvipon Could you have a look, please? |
maxonfjvipon
suggested changes
Jul 11, 2023
eo-maven-plugin/src/test/java/org/eolang/maven/ParseMojoTest.java
Outdated
Show resolved
Hide resolved
@maxonfjvipon Could you have a look one more time, please? |
maxonfjvipon
approved these changes
Jul 11, 2023
@volodya-lombrozo looks good to me, thanks. @yegor256 could you please have a look and merge this one? |
@yegor256 Could you merge that changes, please? |
@rultor merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been done:
attributes
fromFakeMaven
fillUp()
method fromFakeMaven
allTojosWithHash()
method to sethash
for all tojos for all testsForeignTojos.Attribute.TRANSPILED
Closes: #2227
PR-Codex overview
This PR focuses on refactoring the code by removing unused imports, enum values, and methods.
Detailed summary
OptimizeMojoTest
andParseMojoTest
classes.Attribute
enum in theForeignTojos
class.FakeMaven
class.