Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(#2227): Refactor ForeignTojos Attribute #2233

Merged
merged 6 commits into from
Jul 12, 2023

Conversation

volodya-lombrozo
Copy link
Member

@volodya-lombrozo volodya-lombrozo commented Jul 11, 2023

What has been done:

  1. Removed attributes from FakeMaven
  2. Removed fillUp() method from FakeMaven
  3. Added the allTojosWithHash() method to set hash for all tojos for all tests
  4. Removed the unsused attribute: ForeignTojos.Attribute.TRANSPILED

Closes: #2227


PR-Codex overview

This PR focuses on refactoring the code by removing unused imports, enum values, and methods.

Detailed summary

  • Removed unused imports in the OptimizeMojoTest and ParseMojoTest classes.
  • Removed unused enum values and methods in the Attribute enum in the ForeignTojos class.
  • Removed unused methods and attributes in the FakeMaven class.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@volodya-lombrozo
Copy link
Member Author

@maxonfjvipon Could you have a look, please?

@volodya-lombrozo
Copy link
Member Author

@maxonfjvipon Could you have a look one more time, please?

@maxonfjvipon
Copy link
Member

@volodya-lombrozo looks good to me, thanks. @yegor256 could you please have a look and merge this one?

@volodya-lombrozo
Copy link
Member Author

@yegor256 Could you merge that changes, please?

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Jul 12, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit c8979e1 into objectionary:master Jul 12, 2023
12 checks passed
@rultor
Copy link
Contributor

rultor commented Jul 12, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 10min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FakeMaven.java:473-478: Move the method to ForeignTojos...
4 participants