Merge branch 'master' into 3160-enable-pmd-in-eo-runtime

.github/workflows/codecov.yml

@@ -38,7 +38,7 @@ jobs:
     runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v4
-      - uses: teatimeguest/setup-texlive-action@v3.2.1
+      - uses: teatimeguest/setup-texlive-action@v3.3.0
         with:
           update-all-packages: true
           packages: scheme-basic geometry xcolor naive-ebnf microtype etoolbox

.github/workflows/license.yml → .github/workflows/copyrights.yml

@@ -20,42 +20,29 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 # SOFTWARE.
 ---
-name: license
-on:
+name: copyrights
+'on':
   push:
   pull_request:
 jobs:
-  license:
+  copyrights:
     runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v4
+      - uses: yegor256/[email protected]
         with:
-          fetch-depth: 0
-      - run: |
-          set -e
-          find . -type f \( \
-            -name "LICENSE.*" \
-            -o -name "*.sh" \
-            -o -name "*.yml" \
-            -o -name "*.yaml" \
-            -o -name "*.eo" \
-            -o -name "*.xmir" \
-            -o -name "*.xml" \
-            -o -name "*.xsl" \
-            -o -name "*.xsd" \
-            -o -name "*.ini" \
-            -o -name "*.java" \
-            -o -name "*.g4" \
-            -o -name "*.properties" \
-            -o -name "*.groovy" \) > files.txt
-          header="Copyright (c) 2016-$(date +%Y) Objectionary.com"
-          failed="false"
-          while IFS= read -r file; do
-            if ! grep -q "$header" "$file"; then
-              failed="true"
-              echo "No license in: $file"
-            fi
-          done < files.txt
-          if [ "${failed}" == "true" ]; then
-            exit 1
-          fi
+          globs: >-
+            **/LICENSE.txt
+            **/*.sh
+            **/*.yml
+            **/*.yaml
+            **/*.eo
+            **/*.xmir
+            **/*.xml
+            **/*.xsl
+            **/*.xsd
+            **/*.ini
+            **/*.java
+            **/*.g4
+            **/*.properties
+            **/*.groovy

.github/workflows/daily.yml

@@ -30,7 +30,7 @@ jobs:
     runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v4
-      - uses: teatimeguest/setup-texlive-action@v3.2.1
+      - uses: teatimeguest/setup-texlive-action@v3.3.0
         with:
           update-all-packages: true
           packages: scheme-basic geometry xcolor naive-ebnf microtype etoolbox

.github/workflows/ebnf.yml

@@ -38,7 +38,7 @@ jobs:
       - run: |
           sudo apt-get update
           sudo apt-get -y install ghostscript imagemagick texlive-extra-utils pdf2svg inkscape
-      - uses: teatimeguest/setup-texlive-action@v3.2.1
+      - uses: teatimeguest/setup-texlive-action@v3.3.0
         with:
           update-all-packages: true
           packages: scheme-basic geometry xcolor naive-ebnf microtype etoolbox

.github/workflows/sonar.yml

@@ -35,13 +35,13 @@ jobs:
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0
-      - uses: teatimeguest/setup-texlive-action@v3.2.1
+      - uses: teatimeguest/setup-texlive-action@v3.3.0
         with:
           update-all-packages: true
           packages: scheme-basic geometry xcolor naive-ebnf microtype etoolbox
       - uses: actions/setup-java@v4
         with:
-          java-version: 20
+          java-version: 17
           distribution: 'zulu'
       - uses: actions/cache@v4
         with:

.github/workflows/trufflehog-oss.yml

@@ -0,0 +1,43 @@
+# The MIT License (MIT)
+#
+# Copyright (c) 2016-2024 Objectionary.com
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the "Software"), to deal
+# in the Software without restriction, including without limitation the rights
+# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+# copies of the Software, and to permit persons to whom the Software is
+# furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included
+# in all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+# SOFTWARE.
+---
+
+name: trufflehog-oss
+'on':
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
+jobs:
+  trufflehog:
+    runs-on: ubuntu-22.04
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+      - name: Secret Scanning
+        uses: trufflesecurity/trufflehog@main
+        with:
+          extra_args: --only-verified

eo-maven-plugin/README.md

@@ -35,7 +35,7 @@ create a file `pom.xml` with this content (it's just a sample):
       <plugin>
         <groupId>org.eolang</groupId>
         <artifactId>eo-maven-plugin</artifactId>
-        <version>0.38.1</version>
+        <version>0.38.4</version>
         <executions>
           <execution>
             <goals>
@@ -156,7 +156,7 @@ execution within `eo-maven-plugin/pom.xml`:
   ...
   <plugin>
     <artifactId>maven-invoker-plugin</artifactId>
-    <version>0.38.1</version>
+    <version>0.38.4</version>
     <configuration>
         <skipInstallation>true</skipInstallation>
         <skipInvocation>true</skipInvocation>

eo-maven-plugin/pom.xml

@@ -96,25 +96,25 @@ SOFTWARE.
     <dependency>
       <groupId>org.apache.maven</groupId>
       <artifactId>maven-plugin-api</artifactId>
-      <version>3.9.6</version>
+      <version>3.9.7</version>
       <scope>provided</scope>
     </dependency>
     <dependency>
       <groupId>org.apache.maven</groupId>
       <artifactId>maven-model</artifactId>
-      <version>3.9.6</version>
+      <version>3.9.8</version>
       <scope>provided</scope>
     </dependency>
     <dependency>
       <groupId>org.apache.maven</groupId>
       <artifactId>maven-core</artifactId>
-      <version>3.9.6</version>
+      <version>3.9.8</version>
       <scope>provided</scope>
     </dependency>
     <dependency>
       <groupId>org.apache.maven.plugin-tools</groupId>
       <artifactId>maven-plugin-annotations</artifactId>
-      <version>3.13.0</version>
+      <version>3.13.1</version>
       <scope>provided</scope>
     </dependency>
     <dependency>
@@ -126,7 +126,7 @@ SOFTWARE.
     <dependency>
       <groupId>org.apache.maven</groupId>
       <artifactId>maven-compat</artifactId>
-      <version>3.9.6</version>
+      <version>3.9.8</version>
       <scope>test</scope>
     </dependency>
     <dependency>

eo-maven-plugin/src/main/java/org/eolang/maven/PhiMojo.java

@@ -36,6 +36,7 @@
 import java.nio.file.Path;
 import java.nio.file.Paths;
 import java.util.List;
+import net.sf.saxon.expr.instruct.TerminationException;
 import org.apache.maven.plugins.annotations.LifecyclePhase;
 import org.apache.maven.plugins.annotations.Mojo;
 import org.apache.maven.plugins.annotations.Parameter;
@@ -87,6 +88,21 @@ public final class PhiMojo extends SafeMojo {
     )
     private File phiOutputDir;
 
+    /**
+     * Whether {@link PhiMojo} should fail on critical errors or not.
+     * @checkstyle MemberNameCheck (10 lines)
+     */
+    @Parameter(property = "eo.phiFailOnCritical", required = true, defaultValue = "true")
+    @SuppressWarnings({"PMD.ImmutableField", "PMD.LongVariable"})
+    private boolean phiFailOnCritical = true;
+
+    /**
+     * Whether {@link PhiMojo} should skip XMIRs that failed on critical errors.
+     * @checkstyle MemberNameCheck (10 lines)
+     */
+    @Parameter(property = "eo.phiSkipFailed", required = true, defaultValue = "false")
+    private boolean phiSkipFailed;
+
     /**
      * Pass XMIR to Optimizations train or not.
      * This flag is used for test in order not to optimize XMIR twice:
@@ -100,12 +116,7 @@ public final class PhiMojo extends SafeMojo {
     @Override
     public void exec() {
         final Home home = new HmBase(this.phiOutputDir);
-        final Train<Shift> train;
-        if (this.phiOptimize) {
-            train = new ParsingTrain();
-        } else {
-            train = new TrDefault<>();
-        }
+        final Train<Shift> train = this.train();
         final int count = new SumOf(
             new Threads<>(
                 Runtime.getRuntime().availableProcessors(),
@@ -127,8 +138,18 @@ public void exec() {
                                 String.format(".%s", PhiMojo.EXT)
                             )
                         );
+                        int amount;
                         try {
                             home.save(PhiMojo.translated(train, xml), relative);
+                            Logger.info(
+                                this,
+                                "Translated to phi: %[file]s (%[size]s) -> %[file]s (%[size]s)",
+                                processed,
+                                xmir.toFile().length(),
+                                relative,
+                                this.phiOutputDir.toPath().resolve(relative).toFile().length()
+                            );
+                            amount = 1;
                         } catch (final ImpossibleToPhiTranslationException exception) {
                             Logger.debug(
                                 this,
@@ -139,16 +160,20 @@ public void exec() {
                                 String.format("Couldn't translate %s to phi", processed),
                                 exception
                             );
+                        } catch (final IllegalArgumentException exception) {
+                            if (exception.getCause() instanceof TerminationException
+                                && this.phiSkipFailed) {
+                                Logger.info(
+                                    this,
+                                    "%[file]s failed on critical error, but skipped because phiSkipFailed=true",
+                                    processed
+                                );
+                                amount = 0;
+                            } else {
+                                throw exception;
+                            }
                         }
-                        Logger.info(
-                            this,
-                            "Translated to phi: %[file]s (%[size]s) -> %[file]s (%[size]s)",
-                            processed,
-                            xmir.toFile().length(),
-                            relative,
-                            this.phiOutputDir.toPath().resolve(relative).toFile().length()
-                        );
-                        return 1;
+                        return amount;
                     },
                     new Walk(this.phiInputDir.toPath())
                 )
@@ -167,6 +192,36 @@ count, new Rel(this.phiInputDir), new Rel(this.phiOutputDir)
         }
     }
 
+    /**
+     * Build transformations train depends on flags.
+     * @return Transformations train
+     */
+    private Train<Shift> train() {
+        final Train<Shift> train;
+        if (this.phiOptimize) {
+            train = new ParsingTrain();
+        } else {
+            train = new TrDefault<>();
+        }
+        final Train.Temporary<Shift> dependent;
+        if (this.phiFailOnCritical) {
+            dependent = new TrClasspath<>(
+                "/org/eolang/parser/fail-on-critical.xsl",
+                "/org/eolang/maven/phi/to-phi.xsl"
+            );
+        } else {
+            dependent = new TrClasspath<>("/org/eolang/maven/phi/to-phi.xsl");
+        }
+        return new TrJoined<>(
+            train,
+            new TrClasspath<>(
+                "/org/eolang/parser/critical-errors/duplicate-names.xsl",
+                "/org/eolang/maven/phi/incorrect-inners.xsl"
+            ).back(),
+            dependent.back()
+        );
+    }
+
     /**
      * Translate given xmir to phi calculus expression.
      * @param train Train that optimize and translates given xmir
@@ -176,17 +231,7 @@ count, new Rel(this.phiInputDir), new Rel(this.phiOutputDir)
      */
     private static String translated(final Train<Shift> train, final XML xmir)
         throws ImpossibleToPhiTranslationException {
-        final XML translated = new Xsline(
-            new TrJoined<>(
-                train,
-                new TrClasspath<>(
-                    "/org/eolang/parser/critical-errors/duplicate-names.xsl",
-                    "/org/eolang/maven/phi/incorrect-inners.xsl",
-                    "/org/eolang/parser/fail-on-critical.xsl",
-                    "/org/eolang/maven/phi/to-phi.xsl"
-                ).back()
-            )
-        ).pass(xmir);
+        final XML translated = new Xsline(train).pass(xmir);
         Logger.debug(PhiMojo.class, "XML after translation to phi:\n%s", translated);
         final List<String> phi = translated.xpath("phi/text()");
         if (phi.isEmpty()) {

eo-maven-plugin/src/main/java/org/eolang/maven/PullMojo.java

@@ -125,8 +125,18 @@ public void exec() throws IOException {
                     )
                 );
                 names.add(name);
-                tojo.withSource(this.pull(name).toAbsolutePath())
-                    .withHash(new ChNarrow(name.hash()));
+                try {
+                    tojo.withSource(this.pull(name).toAbsolutePath())
+                        .withHash(new ChNarrow(name.hash()));
+                } catch (final IOException exception) {
+                    throw new IOException(
+                        String.format(
+                            "Failed to pull object discovered at %s",
+                            tojo.discoveredAt()
+                        ),
+                        exception
+                    );
+                }
             }
             Logger.info(
                 this,