#2863 replace anonymous class by single implementation to reduce code…

… duplicatoin
objectionary · Mar 5, 2024 · 85ce4c3 · 85ce4c3
1 parent 67d14ee
commit 85ce4c3
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 65 deletions.
diff --git a/.github/workflows/simian.yml b/.github/workflows/simian.yml
@@ -24,4 +24,4 @@ jobs:
       - run: |
           wget --quiet http://public.yegor256.com/simian.jar -O /tmp/simian.jar
       - run: |
-          java -jar /tmp/simian.jar -threshold=25 -excludes=**/gen -excludes=**/it **/*.java
+          java -jar /tmp/simian.jar -threshold=16 -excludes=**/gen -excludes=**/it **/*.java
diff --git a/eo-runtime/src/test/java/org/eolang/DataizedTest.java b/eo-runtime/src/test/java/org/eolang/DataizedTest.java
@@ -48,22 +48,7 @@ void logsCorrectly() {
         final Level before = log.getLevel();
         log.setLevel(Level.ALL);
         final List<LogRecord> logs = new LinkedList<>();
-        final Handler hnd = new Handler() {
-            @Override
-            public void publish(final LogRecord record) {
-                logs.add(record);
-            }
-
-            @Override
-            public void flush() {
-                throw new UnsupportedOperationException("#flush()");
-            }
-
-            @Override
-            public void close() throws SecurityException {
-                throw new UnsupportedOperationException("#close()");
-            }
-        };
+        final Handler hnd = new TestHandler(logs);
         log.addHandler(hnd);
         new Dataized(new Data.ToPhi(1L), log).take();
         log.setLevel(before);
@@ -83,22 +68,7 @@ void logsWhenException() {
         final Level before = log.getLevel();
         log.setLevel(Level.ALL);
         final List<LogRecord> logs = new LinkedList<>();
-        final Handler hnd = new Handler() {
-            @Override
-            public void publish(final LogRecord record) {
-                logs.add(record);
-            }
-
-            @Override
-            public void flush() {
-                throw new UnsupportedOperationException("#flush()");
-            }
-
-            @Override
-            public void close() throws SecurityException {
-                throw new UnsupportedOperationException("#close()");
-            }
-        };
+        final Handler hnd = new TestHandler(logs);
         log.addHandler(hnd);
         final Phi wrong = new PhIncorrect(Phi.Φ);
         IntStream.range(0, 5).forEach(
@@ -125,22 +95,7 @@ void printsShortLogs() throws InterruptedException {
         final Level before = log.getLevel();
         log.setLevel(Level.ALL);
         final List<LogRecord> logs = new LinkedList<>();
-        final Handler hnd = new Handler() {
-            @Override
-            public void publish(final LogRecord record) {
-                logs.add(record);
-            }
-
-            @Override
-            public void flush() {
-                throw new UnsupportedOperationException("#flush()");
-            }
-
-            @Override
-            public void close() throws SecurityException {
-                throw new UnsupportedOperationException("#close()");
-            }
-        };
+        final Handler hnd = new TestHandler(logs);
         log.addHandler(hnd);
         final Thread thread = new Thread(
             () -> {
@@ -170,22 +125,7 @@ void printsLongLogs() throws InterruptedException {
         final Level before = log.getLevel();
         log.setLevel(Level.ALL);
         final List<LogRecord> logs = new LinkedList<>();
-        final Handler hnd = new Handler() {
-            @Override
-            public void publish(final LogRecord record) {
-                logs.add(record);
-            }
-
-            @Override
-            public void flush() {
-                throw new UnsupportedOperationException("#flush()");
-            }
-
-            @Override
-            public void close() throws SecurityException {
-                throw new UnsupportedOperationException("#close()");
-            }
-        };
+        final Handler hnd = new TestHandler(logs);
         log.addHandler(hnd);
         final Thread thread = new Thread(
             () -> {
@@ -261,4 +201,28 @@ public static class PhiDec extends PhDefault {
         }
     }
 
+    private static class TestHandler extends Handler {
+        final List<LogRecord> logs;
+
+        TestHandler(final List<LogRecord> logs) {
+            this.logs = logs;
+        }
+
+        @Override
+        public void publish(final LogRecord record) {
+            logs.add(record);
+        }
+
+        @Override
+        public void flush() {
+            throw new UnsupportedOperationException("#flush()");
+        }
+
+        @Override
+        public void close() throws SecurityException {
+            throw new UnsupportedOperationException("#close()");
+        }
+
+    }
+
 }