Suppress exception for from_unixtime function

oap-project · Nov 11, 2023 · e5960e2 · e5960e2
1 parent b24cfeb
commit e5960e2
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/velox/functions/sparksql/DateTimeFunctions.h b/velox/functions/sparksql/DateTimeFunctions.h
@@ -181,8 +181,16 @@ struct FromUnixtimeFunction {
       mysqlDateTime_ = buildJodaDateTimeFormatter(
           std::string_view(timeFormat.data(), timeFormat.size()));
     }
-    Timestamp timestamp = Timestamp::fromMillis(1000 * second);
-    auto formattedResult = mysqlDateTime_->format(timestamp, sessionTimeZone_);
+    Timestamp timestamp = Timestamp::fromSecond(second);
+    std::string formattedResult;
+    try {
+      formattedResult = mysqlDateTime_->format(timestamp, sessionTimeZone_);
+    } catch (const VeloxUserError& e) {
+      // Suppress exception caused by integer overflow or
+      // out of [-32767-01-01, 32767-12-31] date range.
+      formattedResult =
+          mysqlDateTime_->format(Timestamp(0, 0), sessionTimeZone_);
+    }
     auto resultSize = formattedResult.size();
     result.resize(resultSize);
     if (resultSize != 0) {

diff --git a/velox/type/Timestamp.h b/velox/type/Timestamp.h
@@ -122,6 +122,10 @@ struct Timestamp {
   std::chrono::time_point<std::chrono::system_clock, std::chrono::milliseconds>
   toTimePoint() const;
 
+  static Timestamp fromSecond(int64_t second) {
+    return Timestamp(second, 0);
+  }
+
   static Timestamp fromMillis(int64_t millis) {
     if (millis >= 0 || millis % 1'000 == 0) {
       return Timestamp(millis / 1'000, (millis % 1'000) * 1'000'000);