fix test

Signed-off-by: Yuan Zhou <[email protected]>
oap-project · Feb 6, 2024 · 6e0eb08 · 6e0eb08
1 parent 20ffe58
commit 6e0eb08
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 7 deletions.
diff --git a/velox/common/memory/tests/MemoryAllocatorTest.cpp b/velox/common/memory/tests/MemoryAllocatorTest.cpp
@@ -30,6 +30,10 @@
 #include <gmock/gmock-matchers.h>
 #include <gtest/gtest.h>
 
+#ifdef linux
+#include <fstream>
+#endif // linux
+
 DECLARE_int32(velox_memory_pool_mb);
 DECLARE_bool(velox_memory_leak_check_enabled);
 
@@ -1407,7 +1411,7 @@ TEST_P(MemoryAllocatorTest, contiguousAllocation) {
     ASSERT_EQ(movedAllocation.pool(), pool_.get());
     *allocation = std::move(movedAllocation);
     ASSERT_TRUE(!allocation->empty()); // NOLINT
-    ASSERT_TRUE(movedAllocation.empty());
+    ASSERT_TRUE(movedAllocation.empty()); // NOLINT
     ASSERT_EQ(allocation->pool(), pool_.get());
   }
   ASSERT_THROW(allocation->setPool(pool_.get()), VeloxRuntimeError);

diff --git a/velox/vector/arrow/tests/ArrowBridgeArrayTest.cpp b/velox/vector/arrow/tests/ArrowBridgeArrayTest.cpp
@@ -185,8 +185,9 @@ class ArrowBridgeArrayExportTest : public testing::Test {
                   << "mismatch at index " << i;
               break;
             default:
-              VELOX_USER_FAIL(fmt::format(
-                  "Timestamp unit not supported: {}.", options_.timestampUnit));
+              VELOX_USER_FAIL(
+                  "Timestamp unit not supported: {}.",
+                  static_cast<int>(options_.timestampUnit));
           }
         } else {
           EXPECT_EQ(inputData[i], values[i]) << "mismatch at index " << i;
@@ -1033,8 +1034,9 @@ class ArrowBridgeArrayImportTest : public ArrowBridgeArrayExportTest {
               rawValues[i] = inputValues[i]->toNanos();
               break;
             default:
-              VELOX_USER_FAIL(fmt::format(
-                  "Timestamp unit not supported: {}.", options_.timestampUnit));
+              VELOX_USER_FAIL(
+                  "Timestamp unit not supported: {}.",
+                  static_cast<int>(options_.timestampUnit));
           }
         } else {
           rawValues[i] = *inputValues[i];
@@ -1179,8 +1181,9 @@ class ArrowBridgeArrayImportTest : public ArrowBridgeArrayExportTest {
                   << "mismatch at index " << i;
               break;
             default:
-              VELOX_USER_FAIL(fmt::format(
-                  "Timestamp unit not supported: {}.", options_.timestampUnit));
+              VELOX_USER_FAIL(
+                  "Timestamp unit not supported: {}.",
+                  static_cast<int>(options_.timestampUnit));
           }
         }
       } else {