Skip to content
This repository has been archived by the owner on Jan 3, 2023. It is now read-only.

[SQL-DS-CACHE-89][POAE7-1016] Fix agg result when column value could be null #90

Merged
merged 1 commit into from
Apr 15, 2021

Conversation

jikunshang
Copy link
Collaborator

What changes were proposed in this pull request?

Fix agg result when column value could be null, previous behavior will evaluate this null value.

How was this patch tested?

manual tests, for a column which data could be null, select count(*), count(column_name) from table result would be different.

@github-actions
Copy link

#89

@jikunshang
Copy link
Collaborator Author

@xieqi @winningsix @iyupeng Please take a review, thanks.

@jikunshang jikunshang merged commit d1b1b50 into oap-project:ape Apr 15, 2021
@jikunshang jikunshang deleted the poae7-1016 branch April 15, 2021 05:35
@iyupeng
Copy link
Collaborator

iyupeng commented Apr 15, 2021

Sorry for the late review:

  • nullVector is not set in sum, min, max, and count
  • sum, min, max should take account that all input values may be null

@jikunshang
Copy link
Collaborator Author

Sorry for the late review:

  • nullVector is not set in sum, min, max, and count
  • sum, min, max should take account that all input values may be null

Thanks for your comments, will address these in another pr.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants